Re: [Qemu-devel] [PATCH] usb-bus: fix no params

[Aurelien Jarno <aurelien@aurel32.net>]

On Fri, Mar 19, 2010 at 12:59:24PM +0800, TeLeMan wrote:
> The "params" is never NULL and the usb hid devices have no params.

This looks plainly wrong. With your patch, usb devices which don't
accept parameters, will accept and ignore them.

What are you trying to fix here?

> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
>  hw/usb-bus.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/usb-bus.c b/hw/usb-bus.c
> index ce8a694..f3f1ed6 100644
> --- a/hw/usb-bus.c
> +++ b/hw/usb-bus.c
> @@ -299,10 +299,6 @@ USBDevice *usbdevice_create(const char *cmdline)
>      }
> 
>      if (!usb->usbdevice_init) {
> -        if (params) {
> -            error_report("usbdevice %s accepts no params", driver);
> -            return NULL;
> -        }
>          return usb_create_simple(bus, usb->qdev.name);
>      }
>      return usb->usbdevice_init(params);
> -- 
> 1.6.5.1.1367.gcd48
> --
> SUN OF A BEACH
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net