diff for duplicates of <20100327145950.GG5069@bicker> diff --git a/a/1.txt b/N1/1.txt index 327fd0e..5df27c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,8 +12,8 @@ index 17956ff..b68b778 100644 for (i = 0; i < mdev->resync->nr_elements; i++) { e = lc_element_by_index(mdev->resync, i); bm_ext = e ? lc_entry(e, struct bm_extent, lce) : NULL; -- if (bm_ext->lce.lc_number = LC_FREE) -+ if (!bm_ext || bm_ext->lce.lc_number = LC_FREE) +- if (bm_ext->lce.lc_number == LC_FREE) ++ if (!bm_ext || bm_ext->lce.lc_number == LC_FREE) continue; - if (bm_ext->lce.lc_number = mdev->resync_wenr) { + if (bm_ext->lce.lc_number == mdev->resync_wenr) { dev_info(DEV, "dropping %u in drbd_rs_del_all, apparently" diff --git a/a/content_digest b/N1/content_digest index 854bf48..6ec5a1e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,12 +1,12 @@ "From\0Dan Carpenter <error27@gmail.com>\0" - "Subject\0[patch] drbd: potential null dereference\0" - "Date\0Sat, 27 Mar 2010 14:59:50 +0000\0" + "Subject\0[Drbd-dev] [patch] drbd: potential null dereference\0" + "Date\0Sat, 27 Mar 2010 17:59:50 +0300\0" "To\0Lars Ellenberg <drbd-dev@lists.linbit.com>\0" - "Cc\0Jens Axboe <jens.axboe@oracle.com>" + "Cc\0linux-kernel@vger.kernel.org" + kernel-janitors@vger.kernel.org Philipp Reisner <philipp.reisner@linbit.com> drbd-user@lists.linbit.com - linux-kernel@vger.kernel.org - " kernel-janitors@vger.kernel.org\0" + " Jens Axboe <jens.axboe@oracle.com>\0" "\00:1\0" "b\0" "If \"e\" is NULL then \"bm_ext\" would be NULL too.\n" @@ -23,10 +23,10 @@ " \t\tfor (i = 0; i < mdev->resync->nr_elements; i++) {\n" " \t\t\te = lc_element_by_index(mdev->resync, i);\n" " \t\t\tbm_ext = e ? lc_entry(e, struct bm_extent, lce) : NULL;\n" - "-\t\t\tif (bm_ext->lce.lc_number = LC_FREE)\n" - "+\t\t\tif (!bm_ext || bm_ext->lce.lc_number = LC_FREE)\n" + "-\t\t\tif (bm_ext->lce.lc_number == LC_FREE)\n" + "+\t\t\tif (!bm_ext || bm_ext->lce.lc_number == LC_FREE)\n" " \t\t\t\tcontinue;\n" - " \t\t\tif (bm_ext->lce.lc_number = mdev->resync_wenr) {\n" + " \t\t\tif (bm_ext->lce.lc_number == mdev->resync_wenr) {\n" " \t\t\t\tdev_info(DEV, \"dropping %u in drbd_rs_del_all, apparently\"" -b8bb99a1b3f873879c87b4df0511d8a889b68e3e184a5da097e13060c009195d +7ee3e7677d8378c108beea60b049ef3280990680b295cc9c5932d5d5c2068866
diff --git a/a/1.txt b/N2/1.txt index 327fd0e..5df27c1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -12,8 +12,8 @@ index 17956ff..b68b778 100644 for (i = 0; i < mdev->resync->nr_elements; i++) { e = lc_element_by_index(mdev->resync, i); bm_ext = e ? lc_entry(e, struct bm_extent, lce) : NULL; -- if (bm_ext->lce.lc_number = LC_FREE) -+ if (!bm_ext || bm_ext->lce.lc_number = LC_FREE) +- if (bm_ext->lce.lc_number == LC_FREE) ++ if (!bm_ext || bm_ext->lce.lc_number == LC_FREE) continue; - if (bm_ext->lce.lc_number = mdev->resync_wenr) { + if (bm_ext->lce.lc_number == mdev->resync_wenr) { dev_info(DEV, "dropping %u in drbd_rs_del_all, apparently" diff --git a/a/content_digest b/N2/content_digest index 854bf48..bb44dcc 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[patch] drbd: potential null dereference\0" - "Date\0Sat, 27 Mar 2010 14:59:50 +0000\0" + "Date\0Sat, 27 Mar 2010 17:59:50 +0300\0" "To\0Lars Ellenberg <drbd-dev@lists.linbit.com>\0" "Cc\0Jens Axboe <jens.axboe@oracle.com>" Philipp Reisner <philipp.reisner@linbit.com> @@ -23,10 +23,10 @@ " \t\tfor (i = 0; i < mdev->resync->nr_elements; i++) {\n" " \t\t\te = lc_element_by_index(mdev->resync, i);\n" " \t\t\tbm_ext = e ? lc_entry(e, struct bm_extent, lce) : NULL;\n" - "-\t\t\tif (bm_ext->lce.lc_number = LC_FREE)\n" - "+\t\t\tif (!bm_ext || bm_ext->lce.lc_number = LC_FREE)\n" + "-\t\t\tif (bm_ext->lce.lc_number == LC_FREE)\n" + "+\t\t\tif (!bm_ext || bm_ext->lce.lc_number == LC_FREE)\n" " \t\t\t\tcontinue;\n" - " \t\t\tif (bm_ext->lce.lc_number = mdev->resync_wenr) {\n" + " \t\t\tif (bm_ext->lce.lc_number == mdev->resync_wenr) {\n" " \t\t\t\tdev_info(DEV, \"dropping %u in drbd_rs_del_all, apparently\"" -b8bb99a1b3f873879c87b4df0511d8a889b68e3e184a5da097e13060c009195d +9153bd1100dd4a11328938c24e892d3d0aee61d05dffda7671c1c6dc0f31eb64
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.