From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvrT6-0002kz-It for qemu-devel@nongnu.org; Sun, 28 Mar 2010 08:19:52 -0400 Received: from [140.186.70.92] (port=52826 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvrT5-0002kO-CC for qemu-devel@nongnu.org; Sun, 28 Mar 2010 08:19:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvrT4-0002Wg-30 for qemu-devel@nongnu.org; Sun, 28 Mar 2010 08:19:51 -0400 Received: from verein.lst.de ([213.95.11.210]:39010) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvrT3-0002WS-Ov for qemu-devel@nongnu.org; Sun, 28 Mar 2010 08:19:50 -0400 Date: Sun, 28 Mar 2010 14:19:47 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [RFC][PATCH 1/7] qemu-config: qemu_read_config_file() reads the normal config file Message-ID: <20100328121947.GA12007@lst.de> References: <1268672915-12233-1-git-send-email-kwolf@redhat.com> <1268672915-12233-2-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268672915-12233-2-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Mon, Mar 15, 2010 at 06:08:29PM +0100, Kevin Wolf wrote: > Introduce a new function qemu_read_config_file which reads the VM configuration > from a config file. Unlike qemu_config_parse it doesn't take a open file but a > filename and reduces code duplication as a side effect. > > Signed-off-by: Kevin Wolf Looks good, Reviewed-by: Christoph Hellwig