From: Al Viro <viro@ZenIV.linux.org.uk>
To: Fran?ois Romieu <romieu@fr.zoreil.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
David Miller <davem@davemloft.net>,
timo.teras@iki.fi, ivecera@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: fix broken register writes
Date: Mon, 29 Mar 2010 03:17:30 +0100 [thread overview]
Message-ID: <20100329021730.GI30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100329010346.GH30031@ZenIV.linux.org.uk>
On Mon, Mar 29, 2010 at 02:03:46AM +0100, Al Viro wrote:
> On Sun, Mar 28, 2010 at 11:19:24PM +0100, Al Viro wrote:
>
> > > > Thanks Fran?ois. Which hardware have you tested this on so far ?
> > >
> > > 10ec:8169 (rev 10) / RTL8169sb/8110sb / XID 10000000
> > >
> > > Timo's is a 10ec:8167 / RTL8169sc/8110sc / XID 18000000. He only tested
> > > the MAC[04] part.
> >
> > FWIW, XID18000000 here (J7F4) loses MAC4 on shutdown; hadn't tested the patch
> > yet. 2.6.26 (on that box) and 2.6.31 (on identical mb) work, 2.6.33 doesn't.
> > I suspect that bisect would lead to commit cc098dc70 (i.e. the place where we
> > started to set address on shutdown). One more data point: ifconfig hw ether
> > done under 2.6.26 did restore the address. And that's the same function,
> > isn't it?
>
> As the matter of fact, ifconfig eth0 hw ether .... ends up zeroing upper
> 32 bits on old kernels once in a while.
BTW, patch from upthread doesn't help on that box, and neither does
simple reordering of MAC0 and MAC4 writes. Adding reads of MAC0 and
MAC4 after corresponding writes seems to work.
next prev parent reply other threads:[~2010-03-29 2:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 10:28 r8169 mac reading/writing broken Timo Teräs
2010-03-27 11:40 ` François Romieu
2010-03-27 11:46 ` Timo Teräs
2010-03-27 12:03 ` François Romieu
2010-03-27 12:16 ` Timo Teräs
2010-03-27 12:25 ` Timo Teräs
2010-03-27 12:26 ` François Romieu
2010-03-27 12:32 ` Timo Teräs
2010-03-27 20:37 ` Timo Teräs
2010-03-27 21:11 ` François Romieu
2010-03-27 23:20 ` Ben Hutchings
2010-03-27 23:30 ` David Miller
2010-03-28 0:31 ` [PATCH] r8169: fix broken register writes François Romieu
2010-03-28 0:47 ` Ben Hutchings
2010-03-28 21:28 ` François Romieu
2010-03-28 22:19 ` Al Viro
2010-03-29 1:03 ` Al Viro
2010-03-29 2:17 ` Al Viro [this message]
2010-03-31 20:27 ` =?unknown-8bit?B?RnJhbsOnb2lz?= Romieu
2010-03-29 21:11 ` François Romieu
2010-03-28 2:38 ` David Miller
2010-03-28 22:04 ` François Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329021730.GI30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.