All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: rt2x00 Users List <users@rt2x00.serialmonkey.com>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] rt2500usb: fix powersaving random failures
Date: Mon, 29 Mar 2010 09:56:53 +0200	[thread overview]
Message-ID: <201003290956.54234.linux@rainbow-software.org> (raw)

This patch seems to fix random powersaving failure where the device state is
stuck at 1 (STATE_SLEEP) and does not change to 3 (STATE_AWAKE), resulting in
to associate and these error messages:
phy0 -> rt2500usb_set_device_state: Error - Device failed to enter state 3 (-16).
No probe response from AP xx:xx:xx:xx:xx:xx after 500ms, disconnecting.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

--- linux-2.6.34-rc2-orig/drivers/net/wireless/rt2x00/rt2500usb.c	2010-03-20 02:17:57.000000000 +0100
+++ linux-2.6.34-rc2/drivers/net/wireless/rt2x00/rt2500usb.c	2010-03-29 09:38:02.000000000 +0200
@@ -648,6 +648,10 @@
 
 		rt2x00_set_field16(&reg, MAC_CSR18_AUTO_WAKE, 1);
 		rt2500usb_register_write(rt2x00dev, MAC_CSR18, reg);
+	} else {
+		rt2500usb_register_read(rt2x00dev, MAC_CSR18, &reg);
+		rt2x00_set_field16(&reg, MAC_CSR18_AUTO_WAKE, 0);
+		rt2500usb_register_write(rt2x00dev, MAC_CSR18, reg);
 	}
 
 	rt2x00dev->ops->lib->set_device_state(rt2x00dev, state);

-- 
Ondrej Zary

             reply	other threads:[~2010-03-29  7:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29  7:56 Ondrej Zary [this message]
2010-03-29 19:47 ` [PATCH] rt2500usb: fix powersaving random failures Gertjan van Wingerde
2010-03-29 21:00   ` [rt2x00-users] " Ivo van Doorn
2010-03-30  5:11     ` Gertjan van Wingerde
2010-03-30  6:01       ` Ondrej Zary
2010-03-30 12:33       ` Ondrej Zary
2010-03-30 12:38         ` Ondrej Zary
2010-03-30 12:56         ` Matthijs Kooijman
2010-03-30 20:09           ` [PATCH] [RFC] rt2500pci: fix powersaving Ondrej Zary
2010-03-30 20:32             ` Matthijs Kooijman
2010-03-30 20:38               ` [rt2x00-users] " Gertjan van Wingerde
2010-03-30 21:02             ` Gertjan van Wingerde
2010-03-30 21:35               ` Ondrej Zary
2010-03-30 21:44                 ` Gertjan van Wingerde
2010-03-31 17:41             ` Matthijs Kooijman
2010-03-31 18:38               ` Gertjan van Wingerde
2010-03-31 18:46                 ` Gertjan van Wingerde
2010-03-31 19:00                   ` [rt2x00-users] " Matthijs Kooijman
2010-04-03 14:11                     ` Gertjan van Wingerde
2010-04-03 15:28                       ` Matthijs Kooijman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003290956.54234.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.