From: "Stephen R. van den Berg" <srb@cuci.nl>
To: "Henrik Grubbstr??m (Grubba)" <grubba@grubba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] convert: Safer handling of $Id$ contraction.
Date: Mon, 29 Mar 2010 14:46:23 +0200 [thread overview]
Message-ID: <20100329124623.GD22480@cuci.nl> (raw)
In-Reply-To: <a75a46b1b6fdb9d52f608643676512e87474e16d.1269860022.git.grubba@grubba.org>
Henrik Grubbstr??m (Grubba) wrote:
>The code to contract $Id:xxxxx$ strings could eat an arbitrary amount
>of source text if the terminating $ was lost. It now refuses to
>contract $Id:xxxxx$ strings spanning multiple lines.
Looks good.
Acked-By: Stephen R. van den Berg <srb@cuci.nl>
--
Stephen.
next prev parent reply other threads:[~2010-03-29 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 11:28 [PATCH 0/5] ident attribute related patches (resend w/ testsuite v3) Henrik Grubbström (Grubba)
2010-03-29 11:28 ` [PATCH 1/5] convert: Safer handling of $Id$ contraction Henrik Grubbström (Grubba)
2010-03-29 12:46 ` Stephen R. van den Berg [this message]
2010-03-29 11:28 ` [PATCH 2/5] convert: Keep foreign $Id$ on checkout Henrik Grubbström (Grubba)
2010-03-29 12:48 ` Stephen R. van den Berg
2010-03-29 11:28 ` [PATCH 3/5] convert: Use the enum constant SAFE_CRLF_FALSE Henrik Grubbström (Grubba)
2010-03-29 12:49 ` Stephen R. van den Berg
2010-04-01 19:53 ` Junio C Hamano
2010-03-29 11:28 ` [PATCH 4/5] convert: Inhibit contraction of foreign $Id$ during stats Henrik Grubbström (Grubba)
2010-03-29 12:51 ` Stephen R. van den Berg
2010-04-01 19:56 ` Junio C Hamano
2010-04-06 11:53 ` Henrik Grubbström
2010-03-29 11:28 ` [PATCH 5/5] convert: Added core.refilteronadd feature Henrik Grubbström (Grubba)
2010-03-29 12:54 ` Stephen R. van den Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329124623.GD22480@cuci.nl \
--to=srb@cuci.nl \
--cc=git@vger.kernel.org \
--cc=grubba@grubba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.