From: Matthew Wilcox <matthew@wil.cx>
To: Stefan Bader <stefan.bader@canonical.com>
Cc: mingo@elte.hu, hpa@zytor.com, linux-kernel@vger.kernel.org,
James.Bottomley@suse.de
Subject: Re: [PATCH] dma-mapping: Remove WARN_ON in dma_free_coherent
Date: Mon, 29 Mar 2010 14:41:24 -0600 [thread overview]
Message-ID: <20100329204123.GA32165@parisc-linux.org> (raw)
In-Reply-To: <1269886161-2616-1-git-send-email-stefan.bader@canonical.com>
On Mon, Mar 29, 2010 at 08:09:21PM +0200, Stefan Bader wrote:
> But it seems modifying that driver would be a bigger effort and maybe
> not really worthwile as it is a rather old driver. On the other side
> I was told [1] that this WARN_ON applies only to ARM which could sleep
> in the free path and it is just bogus for X86. As the code is in
> arch/x86 it would never be used for anything else than X86 and if
> its truely bogus on X86, couldn't it get removed?
My suggestion was that you remove it from the Ubuntu kernel, not submit
it upstream.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-03-29 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 18:09 [PATCH] dma-mapping: Remove WARN_ON in dma_free_coherent Stefan Bader
2010-03-29 20:41 ` Matthew Wilcox [this message]
2010-03-29 20:50 ` Stefan Bader
2010-03-29 20:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329204123.GA32165@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.