From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Tue, 30 Mar 2010 12:30:30 +0000 Subject: Re: [PATCH 03/24] usb/otg/isp1301_omap: Fix dangling pointer Message-Id: <20100330123030.GE29472@pengutronix.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="//IivP0gvsAy3Can" List-Id: References: <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> <1269094385-16114-4-git-send-email-w.sang@pengutronix.de> <20100320200907.GA3861@gandalf> In-Reply-To: <20100320200907.GA3861@gandalf> To: Felipe Balbi Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Brownell , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --//IivP0gvsAy3Can Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 20, 2010 at 10:09:07PM +0200, Felipe Balbi wrote: > On Sat, Mar 20, 2010 at 03:12:44PM +0100, Wolfram Sang wrote: > > Fix this i2c-driver which missed setting clientdata to NULL before free= ing the > > structure it points to. Found by a semantic patch, but fixed by hand. > >=20 > > Signed-off-by: Wolfram Sang > > Cc: David Brownell > > Cc: Greg Kroah-Hartman >=20 > Acked-by: Felipe Balbi >=20 > Greg, >=20 > if you wish, you can take queue it already unless Dave has any comments. Thanks but: please drop this this patch. We reached an agreement that a) setting the clientdata-pointer to NULL should be done in the i2c-core [1] and b) how to= do it. Based on that, I will do the modification of the i2c-core for 2.6.34 (a= s it fixes the dangling pointers) and then create one single patch removing the = then superflous calls to i2c_set_clientdata for 2.6.35 (as it is a cleanup). If = you already applied the above patch to your branch, you don't have to revert; we will fix it for you in the next round. Sorry for the detour! Kind regards, Wolfram [1] http://thread.gmane.org/gmane.linux.drivers.i2c/5674/focus=3D5729 --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --//IivP0gvsAy3Can Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkux7uYACgkQD27XaX1/VRs8lgCfdSWmMqeV5ofY0y5my3O2weiK XNUAnjk+HWCG3Djbomb6ueKiMunzc7RX =885N -----END PGP SIGNATURE----- --//IivP0gvsAy3Can-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 03/24] usb/otg/isp1301_omap: Fix dangling pointer Date: Tue, 30 Mar 2010 14:30:30 +0200 Message-ID: <20100330123030.GE29472@pengutronix.de> References: <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> <1269094385-16114-4-git-send-email-w.sang@pengutronix.de> <20100320200907.GA3861@gandalf> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="//IivP0gvsAy3Can" Return-path: Content-Disposition: inline In-Reply-To: <20100320200907.GA3861@gandalf> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Brownell , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --//IivP0gvsAy3Can Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 20, 2010 at 10:09:07PM +0200, Felipe Balbi wrote: > On Sat, Mar 20, 2010 at 03:12:44PM +0100, Wolfram Sang wrote: > > Fix this i2c-driver which missed setting clientdata to NULL before free= ing the > > structure it points to. Found by a semantic patch, but fixed by hand. > >=20 > > Signed-off-by: Wolfram Sang > > Cc: David Brownell > > Cc: Greg Kroah-Hartman >=20 > Acked-by: Felipe Balbi >=20 > Greg, >=20 > if you wish, you can take queue it already unless Dave has any comments. Thanks but: please drop this this patch. We reached an agreement that a) setting the clientdata-pointer to NULL should be done in the i2c-core [1] and b) how to= do it. Based on that, I will do the modification of the i2c-core for 2.6.34 (a= s it fixes the dangling pointers) and then create one single patch removing the = then superflous calls to i2c_set_clientdata for 2.6.35 (as it is a cleanup). If = you already applied the above patch to your branch, you don't have to revert; we will fix it for you in the next round. Sorry for the detour! Kind regards, Wolfram [1] http://thread.gmane.org/gmane.linux.drivers.i2c/5674/focus=3D5729 --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --//IivP0gvsAy3Can Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkux7uYACgkQD27XaX1/VRs8lgCfdSWmMqeV5ofY0y5my3O2weiK XNUAnjk+HWCG3Djbomb6ueKiMunzc7RX =885N -----END PGP SIGNATURE----- --//IivP0gvsAy3Can-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754791Ab0C3Man (ORCPT ); Tue, 30 Mar 2010 08:30:43 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48548 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643Ab0C3Mal (ORCPT ); Tue, 30 Mar 2010 08:30:41 -0400 Date: Tue, 30 Mar 2010 14:30:30 +0200 From: Wolfram Sang To: Felipe Balbi Cc: kernel-janitors@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, David Brownell , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 03/24] usb/otg/isp1301_omap: Fix dangling pointer Message-ID: <20100330123030.GE29472@pengutronix.de> References: <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> <1269094385-16114-4-git-send-email-w.sang@pengutronix.de> <20100320200907.GA3861@gandalf> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="//IivP0gvsAy3Can" Content-Disposition: inline In-Reply-To: <20100320200907.GA3861@gandalf> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --//IivP0gvsAy3Can Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 20, 2010 at 10:09:07PM +0200, Felipe Balbi wrote: > On Sat, Mar 20, 2010 at 03:12:44PM +0100, Wolfram Sang wrote: > > Fix this i2c-driver which missed setting clientdata to NULL before free= ing the > > structure it points to. Found by a semantic patch, but fixed by hand. > >=20 > > Signed-off-by: Wolfram Sang > > Cc: David Brownell > > Cc: Greg Kroah-Hartman >=20 > Acked-by: Felipe Balbi >=20 > Greg, >=20 > if you wish, you can take queue it already unless Dave has any comments. Thanks but: please drop this this patch. We reached an agreement that a) setting the clientdata-pointer to NULL should be done in the i2c-core [1] and b) how to= do it. Based on that, I will do the modification of the i2c-core for 2.6.34 (a= s it fixes the dangling pointers) and then create one single patch removing the = then superflous calls to i2c_set_clientdata for 2.6.35 (as it is a cleanup). If = you already applied the above patch to your branch, you don't have to revert; we will fix it for you in the next round. Sorry for the detour! Kind regards, Wolfram [1] http://thread.gmane.org/gmane.linux.drivers.i2c/5674/focus=3D5729 --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --//IivP0gvsAy3Can Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkux7uYACgkQD27XaX1/VRs8lgCfdSWmMqeV5ofY0y5my3O2weiK XNUAnjk+HWCG3Djbomb6ueKiMunzc7RX =885N -----END PGP SIGNATURE----- --//IivP0gvsAy3Can--