From: Andrew Morton <akpm@linux-foundation.org>
To: InKi Dae <daeinki@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com
Subject: Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.
Date: Tue, 30 Mar 2010 16:02:57 -0700 [thread overview]
Message-ID: <20100330160257.e5f978a9.akpm@linux-foundation.org> (raw)
In-Reply-To: <90b950fc1003252024i5ba8989bg95f0a81e8e5e708e@mail.gmail.com>
On Fri, 26 Mar 2010 12:24:24 +0900
InKi Dae <daeinki@gmail.com> wrote:
> +static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
> +{
> + int ret;
> +
> + ret = s6e63m0_panel_send_sequence(lcd, SEQ_PANEL_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_DISPLAY_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_GAMMA_SETTING);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ETC_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ACL_ON);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ELVSS_ON);
> +
> + return ret;
> +}
Well. If one call to s6e63m0_panel_send_sequence() returns -ENOMEM and
another call returns -EIO (for example), this function will return some
other, incorrect errno.
Which is a rather minor problem, unless some caller is explicitly
looking for some particular error code, which doesn't happen often.
next prev parent reply other threads:[~2010-03-30 23:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 3:24 [PATCH] added S6E63M0 AMOLED LCD Panel driver InKi Dae
2010-03-30 23:02 ` Andrew Morton [this message]
2010-03-30 23:24 ` [Linux-fbdev-devel] " H Hartley Sweeten
2010-03-31 2:56 ` InKi Dae
2010-03-31 2:41 ` InKi Dae
2010-03-30 23:55 ` Andrew Morton
2010-04-27 19:05 ` Andrew Morton
2010-04-29 3:30 ` InKi Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330160257.e5f978a9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daeinki@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.