From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] lockdep warning in ocfs2 quota
Date: Tue, 30 Mar 2010 12:53:56 -0700 [thread overview]
Message-ID: <20100330195356.GA27285@mail.oracle.com> (raw)
In-Reply-To: <20100330163656.GD3424@quack.suse.cz>
On Tue, Mar 30, 2010 at 06:36:57PM +0200, Jan Kara wrote:
> This is the culprit - we have to do some writes when reading dquot (to
> increase dquot use count and possibly also allocate space for further
> writes) but ocfs2_local_read_dquot is already called with dqio_mutex
> held so when ocfs2_global_read_dquot tries to start a transaction it
> is a violation of lock ordering.
> I guess I'll have to move all the code from ocfs2_local_read_dquot
> to ocfs2_acquire_dquot and do all the handling there with proper locking.
> I'll have a look at it.
Thanks for taking a look. Better we find the inversion sooner!
Joel
--
Life's Little Instruction Book #207
"Swing for the fence."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-03-30 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 22:01 [Ocfs2-devel] lockdep warning in ocfs2 quota Joel Becker
2010-03-30 16:36 ` Jan Kara
2010-03-30 19:53 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330195356.GA27285@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.