All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Goff <thomas.goff@boeing.com>
To: David Miller <davem@davemloft.net>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, netdev@vger.kernel.org
Subject: [PATCH] net_sched: minor netns related cleanup
Date: Tue, 30 Mar 2010 19:43:54 -0700	[thread overview]
Message-ID: <20100331024354.GA6631@boeing.com> (raw)
In-Reply-To: <20100326.201426.05866973.davem@davemloft.net>

These changes were suggested by Alexey Dobriyan <adobriyan@gmail.com>:

  - psched_show() does not use any private data so just pass NULL to
    psched_open()

  - remove unnecessary return statement

Signed-off-by: Tom Goff <thomas.goff@boeing.com>
---
 net/sched/sch_api.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 6d6fe16..c65866d 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1683,7 +1683,7 @@ static int psched_show(struct seq_file *seq, void *v)
 
 static int psched_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, psched_show, PDE(inode)->data);
+	return single_open(file, psched_show, NULL);
 }
 
 static const struct file_operations psched_fops = {
@@ -1708,8 +1708,6 @@ static int __net_init psched_net_init(struct net *net)
 static void __net_exit psched_net_exit(struct net *net)
 {
 	proc_net_remove(net, "psched");
-
-	return;
 }
 #else
 static int __net_init psched_net_init(struct net *net)
-- 
1.6.3.3


  parent reply	other threads:[~2010-03-31  3:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  1:38 [PATCH] netlink: use the appropriate namespace pid Tom Goff
2010-03-22  4:30 ` David Miller
2010-03-24  7:58   ` Alexey Dobriyan
2010-03-24  8:19     ` Alexey Dobriyan
2010-03-27  3:14       ` David Miller
2010-03-31  2:42         ` Goff, Thomas
2010-03-31  2:43         ` Tom Goff [this message]
2010-03-31  2:45           ` [PATCH] net_sched: minor netns related cleanup David Miller
2010-04-02  1:43           ` David Miller
2010-03-24 14:18     ` [PATCH] netlink: use the appropriate namespace pid Goff, Thomas
2010-03-27  3:15       ` David Miller
2010-03-23  3:25 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100331024354.GA6631@boeing.com \
    --to=thomas.goff@boeing.com \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.