From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Alexander Kurz <akurz@blala.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Ken Kawasaki <ken_kawasaki@spring.nifty.jp>,
Magnus Damm <damm@opensource.se>,
Ben Hutchings <ben@decadent.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() and friends (fwd)
Date: Wed, 31 Mar 2010 09:05:48 +0200 [thread overview]
Message-ID: <20100331070548.GA16448@isilmar.linta.de> (raw)
In-Reply-To: <alpine.DEB.1.10.1003302019200.11637@blala.de>
Hey,
On Tue, Mar 30, 2010 at 09:01:41PM +0400, Alexander Kurz wrote:
> I wrote a patch as suggested by kernel-janitors.
> It is my first patch, so I highly welcome comments and hints,
> thanks, Alexander Kurz
>
> ---------- Forwarded message ----------
> Date: Tue, 30 Mar 2010 18:55:33 +0400 (MSD)
> From: Alexander Kurz <akurz@blala.de>
> To: kernel-janitors@vger.kernel.org
> Subject: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info()
> and
> friends
>
> Hello List,
> I wrote a patch replacing some printk() with dev_info() and friends
> for 3com 16-bit PCMCIA cards.
> As this is my first linux patch, comments are welcome,
> thanks, Alexander Kurz
>
> ---------- Forwarded message ----------
> Date: Tue, 30 Mar 2010 18:51:43 +0400
> From: Alexander Kurz <akurz@blala.de>
> To: akurz@blala.de
>
> >From 84616314b126b730528ca10e704d80eabad96ff8 Mon Sep 17 00:00:00 2001
> From: Alexander Kurz <akurz@kbdbabel.org>
> Date: Tue, 30 Mar 2010 12:08:54 +0200
> Subject: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info()
> and friends
> as suggested by kernel-janitors for 3com 16-bit PCMCIA cards
that's two "forwarded message" messages too much :) Other than that, the
only issue I see is that there's a "Signed-off-by"-Line missing. See
Documentation/SubmittingPatches for details.
Best,
Dominik
prev parent reply other threads:[~2010-03-31 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:01 [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() and friends (fwd) Alexander Kurz
2010-03-30 17:22 ` Joe Perches
2010-03-31 12:42 ` [PATCH] net/pcmcia/3c589_cs: using netdev_info and friends where appropriate linux
2010-04-02 2:54 ` David Miller
2010-03-31 7:05 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331070548.GA16448@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=akurz@blala.de \
--cc=ben@decadent.org.uk \
--cc=damm@opensource.se \
--cc=davem@davemloft.net \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.