From: mpatocka@sourceware.org <mpatocka@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/dmeventd/dmeventd.c
Date: 31 Mar 2010 12:01:51 -0000 [thread overview]
Message-ID: <20100331120151.7432.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mpatocka at sourceware.org 2010-03-31 12:01:50
Modified files:
. : WHATS_NEW
daemons/dmeventd: dmeventd.c
Log message:
Don't kill the parent if debugging.
If dmeventd runs with -d flag, it doesn't fork into backgroud.
The command kill(getppid(), SIGTERM) attempts to kill the parent dmeventd
process, however, if there is no parent, it kills whatever process spawned
dmeventd. In case of debugging with gdb, the parent is gdb, thus
kill(getppid(), SIGTERM) kills the debugger.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1490&r2=1.1491
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/dmeventd.c.diff?cvsroot=lvm2&r1=1.57&r2=1.58
--- LVM2/WHATS_NEW 2010/03/31 07:43:41 1.1490
+++ LVM2/WHATS_NEW 2010/03/31 12:01:49 1.1491
@@ -1,5 +1,6 @@
Version 2.02.63 -
================================
+ When dmeventd is not forking because of -d flag, don't kill the parent process
Fix 'make install' when $(builddir) is different from $(srcdir).
Fix dso resource leak in error path of dmeventd.
Use C locales and use_mlockall for dmeventd.
--- LVM2/daemons/dmeventd/dmeventd.c 2010/03/30 14:40:30 1.57
+++ LVM2/daemons/dmeventd/dmeventd.c 2010/03/31 12:01:50 1.58
@@ -1737,7 +1737,8 @@
exit(EXIT_FIFO_FAILURE);
/* Signal parent, letting them know we are ready to go. */
- kill(getppid(), SIGTERM);
+ if (!_debug)
+ kill(getppid(), SIGTERM);
syslog(LOG_NOTICE, "dmeventd ready for processing.");
while (!_exit_now) {
next reply other threads:[~2010-03-31 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 12:01 mpatocka [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-20 14:08 LVM2 ./WHATS_NEW daemons/dmeventd/dmeventd.c zkabelac
2011-02-28 19:47 zkabelac
2011-12-21 13:03 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331120151.7432.qmail@sourceware.org \
--to=mpatocka@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.