From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Felipe Balbi <me@felipebalbi.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
David Brownell <david-b@pacbell.net>,
Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/4] gpiolib: introduce set_debounce method
Date: Wed, 31 Mar 2010 17:59:19 +0300 [thread overview]
Message-ID: <20100331145919.GB6503@nokia.com> (raw)
In-Reply-To: <20100331145059.GA3833@gandalf>
On Wed, Mar 31, 2010 at 04:50:59PM +0200, ext Felipe Balbi wrote:
>On Wed, Mar 31, 2010 at 02:46:28PM +0100, Mark Brown wrote:
>> > +int gpio_set_debounce(unsigned gpio, int value)
>> > +{
>>
>> What are the intended semantics of value here?
>
>debounce time. I just used value because other functions also call it
oh yeah, in miliseconds.
>value.
maybe we could call it debounce. And switch to unsigned. Calling
gpio_set_debounce() with a 0 debounce time should disable it, btw.
--
balbi
next prev parent reply other threads:[~2010-03-31 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 12:27 [RFC/PATCH 0/4] teach gpiolib about gpio debouncing Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-03-31 13:46 ` Mark Brown
2010-03-31 14:50 ` Felipe Balbi
2010-03-31 14:59 ` Felipe Balbi [this message]
2010-03-31 15:04 ` Mark Brown
2010-03-31 15:06 ` Felipe Balbi
2010-03-31 15:11 ` Mark Brown
2010-03-31 15:11 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 12:56 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 0/4] teach gpiolib about debouncing Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-04-02 12:34 ` Mark Brown
2010-05-04 22:40 ` Tony Lindgren
2010-05-05 18:37 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 16:21 ` Mark Brown
2010-03-31 16:29 ` Felipe Balbi
2010-04-01 5:39 ` Felipe Balbi
2010-04-01 9:29 ` Grazvydas Ignotas
2010-04-01 9:32 ` Felipe Balbi
2010-04-01 9:37 ` Grazvydas Ignotas
2010-04-01 10:10 ` Felipe Balbi
2010-04-01 11:20 ` Grazvydas Ignotas
2010-04-01 13:11 ` Jani Nikula
2010-04-01 16:42 ` Felipe Balbi
2010-04-01 18:15 ` Mark Brown
2010-04-01 18:19 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331145919.GB6503@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.