From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC/PATCH 1/4] gpiolib: introduce set_debounce method Date: Wed, 31 Mar 2010 16:11:26 +0100 Message-ID: <20100331151125.GC12394@rakim.wolfsonmicro.main> References: <1270038435-28106-1-git-send-email-felipe.balbi@nokia.com> <1270038435-28106-2-git-send-email-felipe.balbi@nokia.com> <20100331134627.GA27613@sirena.org.uk> <20100331145059.GA3833@gandalf> <20100331145919.GB6503@nokia.com> <20100331150402.GB12394@rakim.wolfsonmicro.main> <20100331150644.GA12603@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39037 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754538Ab0CaPL2 (ORCPT ); Wed, 31 Mar 2010 11:11:28 -0400 Content-Disposition: inline In-Reply-To: <20100331150644.GA12603@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: ext Felipe Balbi , David Brownell , Tony Lindgren , Linux OMAP Mailing List On Wed, Mar 31, 2010 at 06:06:44PM +0300, Felipe Balbi wrote: > On Wed, Mar 31, 2010 at 05:04:03PM +0200, ext Mark Brown wrote: > >Sounds reasonable, a comment would help also. > I'm adding that. And now that I think about it, it's better to pass > debounce time i microseconds. What do you think ? Microseconds is certainly safer, it's much easier to multiply everything by 1000 than run out of room.