From: Mike Frysinger <vapier@gentoo.org>
To: David Howells <dhowells@redhat.com>
Cc: uclinux-dev@uclinux.org, David McCullough <davidm@snapgear.com>,
Greg Ungerer <gerg@uclinux.org>, Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH v2] NOMMU: implement vmap/vunmap with kmalloc
Date: Wed, 31 Mar 2010 15:54:36 -0400 [thread overview]
Message-ID: <201003311554.38473.vapier@gentoo.org> (raw)
In-Reply-To: <14998.1270055484@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 667 bytes --]
On Wednesday 31 March 2010 13:11:24 David Howells wrote:
> How about the attached patch instead? I'd rather not make vmap() generally
> available in NOMMU mode since it can't be implemented in NOMMU mode. Yes,
> vmap() can take a copy of the pages it is given, but you can't guarantee
> that's the right thing to do. It's like a shared-writable mmap.
>
> Instead, why not just override vmap() in firmware_class.c for the one
> instance where we know we're happy with this behaviour?
how about putting this implementation into like vmap_nommu() and only
rewriting vmap() to vmap_nommu() when we know it's safe ? such as this
firmware case ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-03-31 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 4:25 userspace firmware loader, vmap, and nommu Mike Frysinger
2009-10-06 4:38 ` David Woodhouse
2009-10-06 4:56 ` Mike Frysinger
2009-12-21 16:44 ` [PATCH] nommu: implement vmap/vunmap with kmalloc Mike Frysinger
2010-01-07 6:49 ` [uClinux-dev] " Mike Frysinger
2010-01-16 15:57 ` David Howells
2010-03-09 16:11 ` [PATCH v2] NOMMU: " Mike Frysinger
2010-03-31 17:11 ` David Howells
2010-03-31 19:54 ` Mike Frysinger [this message]
2010-03-31 23:06 ` David Howells
2010-03-31 23:07 ` David Howells
2010-03-31 23:10 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003311554.38473.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.