From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] Skip down interfaces (v2) Date: Wed, 31 Mar 2010 11:50:17 -0500 Message-ID: <20100331165017.GB17491@us.ibm.com> References: <1270052634-8170-1-git-send-email-danms@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1270052634-8170-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > This makes the netns checkpoint code skip interfaces that are not up. > Later, we want to make it possible to checkpoint down interfaces with > a flag, but for now this helps prevent people from getting stuck on > stock kernels with various unsupported and persistent virtual interfaces, > such as tunnel devices. > > Changes in v2: > - Fix logic to only skip down interfaces if they're not supported > > Signed-off-by: Dan Smith > Acked-by: Serge Hallyn Looks good, thanks. Tested-by: Serge Hallyn -serge > --- > net/checkpoint_dev.c | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/net/checkpoint_dev.c b/net/checkpoint_dev.c > index bc0415d..e8d574c 100644 > --- a/net/checkpoint_dev.c > +++ b/net/checkpoint_dev.c > @@ -268,7 +268,16 @@ int checkpoint_netns(struct ckpt_ctx *ctx, void *ptr) > goto out; > > for_each_netdev(net, dev) { > - ret = checkpoint_obj(ctx, dev, CKPT_OBJ_NETDEV); > + if (dev->netdev_ops->ndo_checkpoint) > + ret = checkpoint_obj(ctx, dev, CKPT_OBJ_NETDEV); > + else if (dev->flags & IFF_UP) > + ret = -ENOSYS; > + else > + /* TODO: There should be a flag to attempt a > + * checkpoint of downed interfaces, regardless > + * of whether they support checkpoint or not. > + */ > + ret = 0; > if (ret < 0) > break; > } > -- > 1.6.2.5 > > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linux-foundation.org/mailman/listinfo/containers