From: Dave Chinner <david@fromorbit.com>
To: Akshay Lal <akshaylal@google.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: made test 215 backwards compatible with older version of bash.
Date: Thu, 1 Apr 2010 09:33:21 +1100 [thread overview]
Message-ID: <20100331223321.GJ7671@dastard> (raw)
In-Reply-To: <1270062393-5233-1-git-send-email-akshaylal@google.com>
On Wed, Mar 31, 2010 at 12:06:33PM -0700, Akshay Lal wrote:
> Test 215 fails on older versions of bash (2.x), mainly due to the use of
> 'let' for arithemetic operations. Changed to 'expr'.
If that is a problem for older bash versions, then there's going
systemic problems throughout the xfstests suite. The let expression
is used about 80 different places, and I don't see anything special
about test 215 that makes it any different from other uses. i might
be missing something, but there's not much context to go on from
your changelog....
Perhaps upgrading your version of bash might be a better approach?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-31 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Fix for test 215>
2010-03-31 19:06 ` [PATCH] xfstests: made test 215 backwards compatible with older version of bash Akshay Lal
2010-03-31 22:33 ` Dave Chinner [this message]
2010-03-31 23:47 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331223321.GJ7671@dastard \
--to=david@fromorbit.com \
--cc=akshaylal@google.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.