From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: one more warning fix in ocfs2_file_aio_write(), v2
Date: Wed, 31 Mar 2010 17:52:07 -0700 [thread overview]
Message-ID: <20100401005207.GD28680@mail.oracle.com> (raw)
In-Reply-To: <4BABD260.4070600@suse.de>
On Fri, Mar 26, 2010 at 05:15:12AM +0800, Coly Li wrote:
> This patch fixes another compiling warning in ocfs2_file_aio_write() like this,
> fs/ocfs2/file.c: In function ?ocfs2_file_aio_write?:
> fs/ocfs2/file.c:2026: warning: suggest parentheses around ?&&? within ?||?
>
> As Joel suggested, '!ret' is unary, this version removes the wrap from '!ret'.
This patch is now in the fixes branch of ocfs2.git.
Joel
--
"You don't make the poor richer by making the rich poorer."
- Sir Winston Churchill
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-04-01 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 21:15 [Ocfs2-devel] [PATCH] ocfs2: one more warning fix in ocfs2_file_aio_write(), v2 Coly Li
2010-04-01 0:52 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401005207.GD28680@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.