From: Neil Horman <nhorman@tuxdriver.com>
To: Brandon Philips <brandon@ifup.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
michael.s.gilbert@gmail.com, davem@davemeloft.net,
romieu@fr.zoreil.com, eric.dumazet@gmail.com
Subject: Re: [PATCH] r8169: offical fix for CVE-2009-4537 (overlength frame DMAs)
Date: Wed, 31 Mar 2010 21:07:06 -0400 [thread overview]
Message-ID: <20100401010706.GA2069@localhost.localdomain> (raw)
In-Reply-To: <20100401002450.GA19117@jenkins.home.ifup.org>
On Wed, Mar 31, 2010 at 05:24:50PM -0700, Brandon Philips wrote:
> On 12:03 Mon 29 Mar 2010, Neil Horman wrote:
> > Signed-off-by: Neil Horman <nhorman@redhat.com>
>
> Cc: stable@kernel.org?
> Tested-by: Brandon Philips <bphilips@suse.de>
>
> > + if (max_frame != 16383)
> > + printk(KERN_WARNING "WARNING! Changing of MTU on this NIC"
> > + "May lead to frame reception errors!\n");
>
> This needs a space to look right. You might as well add the PFX too:
>
> printk(KERN_WARNING PFX "WARNING! Changing of MTU on this "
> "NIC may lead to frame reception errors!\n");
>
> Thanks Neil.
>
> Cheers,
>
> Brandon
>
Daves already merged my patch, but I'll submit a cleanup patch shortly to take
care of this.
Thanks!
Neil
prev parent reply other threads:[~2010-04-01 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 16:03 [PATCH] r8169: offical fix for CVE-2009-4537 (overlength frame DMAs) Neil Horman
2010-03-29 20:17 ` David Miller
2010-03-29 22:01 ` Ben Hutchings
2010-03-29 22:09 ` David Miller
2010-03-29 22:21 ` Ben Hutchings
2010-03-29 23:44 ` Neil Horman
2010-04-01 0:24 ` Brandon Philips
2010-04-01 1:07 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401010706.GA2069@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=brandon@ifup.org \
--cc=davem@davemeloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.s.gilbert@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.