From: YONETANI Tomokazu <qhwt+git@les.ath.cx>
To: gitster@pobox.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix _XOPEN_SOURCE problem on DragonFly
Date: Thu, 1 Apr 2010 16:37:42 +0900 [thread overview]
Message-ID: <20100401073742.GA52362@les.ath.cx> (raw)
In-Reply-To: <20100304020522.GA76036@les.ath.cx>
Hello.
Is there anything else I need to do to get this in?
On Thu, Mar 04, 2010 at 11:05:22AM +0900, YONETANI Tomokazu wrote:
> Hi.
> DragonFly has the same problem that FreeBSD used to have. Since the
> return value of implicitly declared functions defaults to int, it can
> cause disasters on architectures where sizeof(int) < sizeof(void *).
> The patch below should address this issue.
>
> Best regards,
> YONETANI Tomokazu.
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index a3c4537..e292926 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -55,7 +55,8 @@
> # else
> # define _XOPEN_SOURCE 500
> # endif
> -#elif !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX) && !defined(sgi)
> +#elif !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && \
> + !defined(_M_UNIX) && !defined(sgi) && !defined(__DragonFly__)
> #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
> #endif
next prev parent reply other threads:[~2010-04-01 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 2:05 [PATCH] Fix _XOPEN_SOURCE problem on DragonFly YONETANI Tomokazu
2010-04-01 7:37 ` YONETANI Tomokazu [this message]
2010-04-01 14:37 ` Tay Ray Chuan
2010-04-02 8:02 ` YONETANI Tomokazu
-- strict thread matches above, loose matches on Subject: below --
2010-04-02 7:52 YONETANI Tomokazu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401073742.GA52362@les.ath.cx \
--to=qhwt+git@les.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.