From: Jakub Narebski <jnareb@gmail.com>
To: Mark Rada <marada@uwaterloo.ca>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files
Date: Thu, 1 Apr 2010 10:24:48 +0200 [thread overview]
Message-ID: <201004011024.50615.jnareb@gmail.com> (raw)
In-Reply-To: <4BB430A0.7040700@mailservices.uwaterloo.ca>
On Thu, 1 April 2010, Mark Rada wrote:
> Signed-off-by: Mark Rada <marada@uwaterloo.ca>
For what it's worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>
> diff --git a/Makefile b/Makefile
> index 6d73a8c..5384d33 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2089,7 +2089,7 @@ clean:
> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
> $(MAKE) -C Documentation/ clean
> ifndef NO_PERL
> - $(RM) gitweb/gitweb.cgi
> + $(RM) gitweb/gitweb.{cgi,min.*}
> $(MAKE) -C perl clean
> endif
Minor nit: this would be first line that uses {a,b} shell glob
construct. Why not write it as:
- $(RM) gitweb/gitweb.cgi
+ $(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-04-01 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 5:35 [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files Mark Rada
2010-04-01 8:24 ` Jakub Narebski [this message]
2010-04-01 21:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004011024.50615.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marada@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.