All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Mark Rada <marada@uwaterloo.ca>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv5 6/6] gitweb: update INSTALL to use shorter make target
Date: Thu, 1 Apr 2010 14:25:29 +0200	[thread overview]
Message-ID: <201004011425.29869.jnareb@gmail.com> (raw)
In-Reply-To: <4BB43105.7000201@mailservices.uwaterloo.ca>

On Thu, 1 Apr 2010, Mark Rada wrote:

> Gitweb can be generated by the gitweb/gitweb.cgi target or the gitweb
> target. Since the gitweb target is shorter, I think it would be better
> to have new users be instructed to use it.

Good idea.
  
> -	$ make prefix=/usr gitweb/gitweb.cgi  ;# as yourself
> +	$ make prefix=/usr gitweb.cgi         ;# as yourself
>  	# cp gitweb/git* /var/www/cgi-bin/    ;# as root

But it should read

-	$ make prefix=/usr gitweb/gitweb.cgi  ;# as yourself
+	$ make prefix=/usr gitweb             ;# as yourself

The target is "gitweb", not "gitweb.cgi"
  
>  Alternatively you can use autoconf generated ./configure script to
> @@ -16,7 +15,7 @@ instead
>  
>  	$ make configure                     ;# as yourself
>  	$ ./configure --prefix=/usr          ;# as yourself
> -	$ make gitweb/gitweb.cgi             ;# as yourself
> +	$ make gitweb.cgi                    ;# as yourself

Same here.


> @@ -86,7 +84,7 @@ Build example
>  	     GITWEB_LOGO="/gitweb/git-logo.png" \
>  	     GITWEB_FAVICON="/gitweb/git-favicon.png" \
>  	     bindir=/usr/local/bin \
> -	     gitweb/gitweb.cgi
> +             gitweb.cgi

Same here.  Also spaces in place of TAB.

-- 
Jakub Narebski
Poland

      reply	other threads:[~2010-04-01 12:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01  5:37 [PATCHv5 6/6] gitweb: update INSTALL to use shorter make target Mark Rada
2010-04-01 12:25 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004011425.29869.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=marada@uwaterloo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.