All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: Brian Haley <brian.haley-VXdhtT5mjnY@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] Skip down interfaces (v2)
Date: Thu, 1 Apr 2010 10:37:26 -0500	[thread overview]
Message-ID: <20100401153726.GA14962@hallyn.com> (raw)
In-Reply-To: <4BB4BA26.1050707-VXdhtT5mjnY@public.gmane.org>

Quoting Brian Haley (brian.haley-VXdhtT5mjnY@public.gmane.org):
> Dan Smith wrote:
> > This makes the netns checkpoint code skip interfaces that are not up.
> > Later, we want to make it possible to checkpoint down interfaces with
> > a flag, but for now this helps prevent people from getting stuck on
> > stock kernels with various unsupported and persistent virtual interfaces,
> > such as tunnel devices.
> 
> But devices that are not IFF_UP can still have addresses associated
> with them, wouldn't this cause those addresses to not be
> checkpointed?

Only if it's a device that wouldn't have supported checkpoint anyway.
So if veth0 is down, it'll be checkpointed.  If tunl0 is up, checkpoint
will be refused.  But if tunl0 is down, then it'll just be ignored.
The container didn't want that jerk around anyway, it just couldn't
get rid of it.

-serge

  parent reply	other threads:[~2010-04-01 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 16:23 [PATCH] Skip down interfaces (v2) Dan Smith
     [not found] ` <1270052634-8170-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-31 16:50   ` Serge E. Hallyn
2010-04-01  4:43   ` Oren Laadan
2010-04-01  4:45   ` Oren Laadan
2010-04-01 15:22   ` Brian Haley
     [not found]     ` <4BB4BA26.1050707-VXdhtT5mjnY@public.gmane.org>
2010-04-01 15:37       ` Serge E. Hallyn [this message]
2010-04-01 15:49       ` Dan Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100401153726.GA14962@hallyn.com \
    --to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
    --cc=brian.haley-VXdhtT5mjnY@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.