All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Divyesh Shah <dpshah@google.com>
Cc: vgoyal@redhat.com, linux-kernel@vger.kernel.org,
	nauman@google.com, ctalbott@google.com
Subject: Re: [PATCH 0/3] blkio: IO controller stats
Date: Fri, 2 Apr 2010 08:45:14 +0200	[thread overview]
Message-ID: <20100402064514.GW23510@kernel.dk> (raw)
In-Reply-To: <20100401215541.2843.79107.stgit@austin.mtv.corp.google.com>

On Thu, Apr 01 2010, Divyesh Shah wrote:
> The following series implements some additional stats for IO controller.
> 
> These stats have helped us debug issues with earlier IO controller
> versions and should be useful now as well.
> We've been using these stats for monitoring and debugging problems after the
> fact as these stats can be collected and stored for later use.
> 
> One might argue that most of this information can be exported using blktrace
> when debugging. However, blktrace has non-trivial performance impact and
> cannot be always turned on. These stats provide a way for continuous monitoring
> without losing much performance on rotational disks. We've been able to look
> at these stats and debug issues after problems have been reported in the wild
> and understand the IO pattern of the affected workloads.
> Some of these stats are also a good data source for high-level analysis and
> capacity planning.
> 
> This patchset adds 4 stats and I will send out another patchset later for
> stats like io_merged and some stats that can be turned on only for
> debugging - idle_time (total time spent idling for this blkio_group),
> wait_time (total time spent by the blkio_group waiting before any one of its
> queues got a timeslice). I've tried to breakdown the stats and sent the most
> basic ones here.

Thanks, I think this makes sense. I've applied it for 2.6.35.

-- 
Jens Axboe


      parent reply	other threads:[~2010-04-02  6:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 22:00 [PATCH 0/3] blkio: IO controller stats Divyesh Shah
2010-04-01 22:01 ` [PATCH 1/3] blkio: Remove per-cfqq nr_sectors as we'll be passing Divyesh Shah
2010-04-01 22:01 ` [PATCH 2/3] blkio: Add io controller stats like Divyesh Shah
2010-04-02 18:10   ` Vivek Goyal
2010-04-02 20:53     ` Divyesh Shah
2010-04-05 14:45       ` Vivek Goyal
2010-04-05 22:16         ` Divyesh Shah
2010-04-02 18:17   ` Vivek Goyal
2010-04-02 18:54     ` Divyesh Shah
2010-04-01 22:01 ` [PATCH 3/3] blkio: Increment the blkio cgroup stats for real now Divyesh Shah
2010-04-02 19:10   ` Vivek Goyal
2010-04-02 23:36     ` Divyesh Shah
2010-04-05 15:12       ` Vivek Goyal
2010-04-05 16:53         ` Divyesh Shah
2010-04-05 17:29           ` Vivek Goyal
2010-04-05 22:06             ` Divyesh Shah
2010-04-02  6:45 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100402064514.GW23510@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=ctalbott@google.com \
    --cc=dpshah@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nauman@google.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.