From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@linux.intel.com>, Greg KH <greg@kroah.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Serge Hallyn <serue@us.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Sukadev Bhattiprolu <sukadev@us.ibm.com>,
stable@kernel.org
Subject: Re: [PATCH 1/1] tty: release_one_tty() forgets to put pids
Date: Fri, 2 Apr 2010 20:43:49 +0200 [thread overview]
Message-ID: <20100402184349.GA32229@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1004021040320.3634@i5.linux-foundation.org>
On 04/02, Linus Torvalds wrote:
>
> On Fri, 2 Apr 2010, Oleg Nesterov wrote:
> >
> > release_one_tty(tty) can be called when tty still has a reference
> > to pgrp/session. In this case we leak the pid.
>
> Hmm. Maybe we should have cleared this in tty_release() already. We
> already do some of the session clearing there (but we clear the session in
> the _tasks_ associated with the tty, not the tty session pointer).
Yes, probably we can free them earlier.
But I am very nervous about this change, I tried to defer put_pid()
as much as possible, in case something else uses ->prgp/session
before free_tty_struct().
Oleg.
next prev parent reply other threads:[~2010-04-02 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 12:21 [2.6.31 and later] "struct pid" leak Tetsuo Handa
2010-03-30 15:31 ` Catalin Marinas
2010-03-31 22:17 ` Andrew Morton
2010-04-01 16:52 ` Oleg Nesterov
2010-04-01 17:21 ` Serge E. Hallyn
2010-04-01 17:33 ` Serge E. Hallyn
2010-04-02 15:29 ` Oleg Nesterov
2010-04-02 16:04 ` [PATCH 0/1] tty: release_one_tty() forgets to put pids Oleg Nesterov
2010-04-02 16:05 ` [PATCH 1/1] " Oleg Nesterov
2010-04-02 16:19 ` Oleg Nesterov
2010-04-02 17:46 ` Linus Torvalds
2010-04-02 18:22 ` Eric W. Biederman
2010-04-02 18:48 ` Oleg Nesterov
2010-04-02 18:43 ` Oleg Nesterov [this message]
2010-04-02 20:09 ` Alan Cox
2010-04-03 2:40 ` [PATCH 0/1] " Tetsuo Handa
2010-04-03 3:08 ` Linus Torvalds
2010-04-03 5:15 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402184349.GA32229@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=serue@us.ibm.com \
--cc=stable@kernel.org \
--cc=sukadev@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.