From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc64: Fix array size reported by vmemmap_populate()
Date: Sat, 03 Apr 2010 20:58:03 +0000 [thread overview]
Message-ID: <20100403.135803.268413025.davem@davemloft.net> (raw)
In-Reply-To: <1270327280.12516.368.camel@localhost>
From: David Miller <davem@davemloft.net>
Date: Sat, 03 Apr 2010 13:50:29 -0700 (PDT)
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Sat, 03 Apr 2010 21:41:20 +0100
>
>> vmemmap_populate() attempts to report the used index and total size of
>> vmemmap_table, but it wrongly shifts the total size so that it is
>> always shown as 0.
>>
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
> It's not the total, size, it's the total number of chunks that
> the area supports.
Nevermind, Ben's patch is right, I'll apply it.
VMEMMAP_SIZE is number of entries, not a size in bytes.
Further confusing things is that before the VMEMMAP_SIZE
bug fix the other month, the calculation was "correct"
:-)
prev parent reply other threads:[~2010-04-03 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 20:41 [PATCH] sparc64: Fix array size reported by vmemmap_populate() Ben Hutchings
2010-04-03 20:50 ` David Miller
2010-04-03 20:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100403.135803.268413025.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.