From: Pavel Machek <pavel@ucw.cz>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
David Miller <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [patch 1/2] genirq: Run irq handlers with interrupts disabled
Date: Sat, 3 Apr 2010 06:45:20 +0200 [thread overview]
Message-ID: <20100403044520.GA30558@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1004030046160.32352@localhost.localdomain>
On Sat 2010-04-03 00:51:20, Thomas Gleixner wrote:
> Pavel,
>
> On Fri, 2 Apr 2010, Pavel Machek wrote:
>
> > On Fri 2010-04-02 22:42:51, Thomas Gleixner wrote:
> > > On Fri, 2 Apr 2010, Pavel Machek wrote:
> > >
> > > > On Wed 2010-03-31 13:16:37, Thomas Gleixner wrote:
> > > > > On Tue, 30 Mar 2010, Andi Kleen wrote:
> > > > >
> > > > > > > Why not simply force IRQF_DISABLED for all MSI interrupts. That still
> > > > > > > allows nesting for non MSI ones, but it limits the chance of throwing
> > > > > > > up reasonably well. That's a two liner.
> > > > > > >
> > > > > > > Can you please test whether it resolves the issue at hand ?
> > > > > >
> > > > > > Sorry for the late answer. Got confirmation that this patch
> > > > > > fixes the test case. Thanks.
> > > > >
> > > > > Ok, I'll push it linus wards and cc stable. I think thats the least
> > > > > intrusive safe bet we can have right now.
> > > >
> > > > stable? I'd say thats way too intrusive for -stable...
> > >
> > > So we better let the possible stack overruns unaddressed ?
> >
> > -stable should have no regressions, first and foremost. And this is
> > pretty certain to introduce some, at least on low-powered system with
> > serial ports.
>
> I think you misunderstood what I'm going to push. The patch merily
> forces IRQF_DISABLED for MSI(X) based interrupts. So that does not
> affect low powered systems in any way.
>
> It only affects high end systems where Dave Miller already said he did
> the IRQF_DISABLED magic already in some NIC drivers just to prevent
> that.
Oops, yes, I did; lost in all the mails.
> So I think your fear of regressions for low-powered systems is
> completely unsubstantiated.
Yep. Sorry for the noise.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-04-03 4:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 0:06 [patch 0/2] Run interrupt handlers always with interrupts disabled Thomas Gleixner
2010-03-26 0:06 ` [patch 1/2] genirq: Run irq handlers " Thomas Gleixner
2010-03-26 6:13 ` Andi Kleen
2010-03-26 13:05 ` Thomas Gleixner
2010-03-30 5:33 ` Andi Kleen
2010-03-31 11:16 ` Thomas Gleixner
2010-04-02 9:31 ` Pavel Machek
2010-04-02 20:42 ` Thomas Gleixner
2010-04-02 21:09 ` Pavel Machek
2010-04-02 21:31 ` Peter Zijlstra
2010-04-02 22:51 ` Thomas Gleixner
2010-04-03 4:45 ` Pavel Machek [this message]
2010-04-13 19:33 ` [tip:irq/core] " tip-bot for Ingo Molnar
2010-04-15 7:35 ` Peter Zijlstra
2010-05-25 20:32 ` [patch 1/2] " Venkatesh Pallipadi
2010-03-26 0:06 ` [patch 2/2] genirq: Remove IRQF_DISABLED from core code Thomas Gleixner
2010-03-26 6:20 ` Andi Kleen
2010-03-26 11:19 ` Thomas Gleixner
2010-04-13 19:34 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2010-03-26 3:34 ` [patch 0/2] Run interrupt handlers always with interrupts disabled David Miller
2010-03-26 8:14 ` Russell King
2010-03-26 9:20 ` Ingo Molnar
2010-03-26 9:20 ` Ingo Molnar
2010-03-26 9:28 ` Peter Zijlstra
2010-03-26 12:02 ` Jamie Lokier
2010-03-26 9:59 ` Alan Cox
2010-03-26 10:08 ` Peter Zijlstra
2010-03-26 10:12 ` Andi Kleen
2010-03-26 10:53 ` Ingo Molnar
2010-03-26 12:00 ` Nicolas Pitre
2010-03-26 12:06 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100403044520.GA30558@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.