Re: [PATCH] mac80211: fix ieee80211_meshconf_ie::meshconf_cap type to be u16

[Max Filippov <jcmvbkbc@gmail.com>]

> On Sun,  4 Apr 2010 14:12:44 +0400
> Max Filippov <jcmvbkbc@gmail.com> wrote:
> 
> > According to the current 802.11s draft mesh capability field
> > is 16 bits wide.
> > 
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > ---
> >  include/linux/ieee80211.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> > index 1998495..910b4bc 100644
> > --- a/include/linux/ieee80211.h
> > +++ b/include/linux/ieee80211.h
> > @@ -604,7 +604,7 @@ struct ieee80211_meshconf_ie {
> >  	u8 meshconf_synch;
> >  	u8 meshconf_auth;
> >  	u8 meshconf_form;
> > -	u8 meshconf_cap;
> > +	u16 meshconf_cap;
> >  } __attribute__ ((packed));
> >  
> >  /**
> 
> May be it should be:
> 
> struct ieee80211_meshconf_ie {
>         u32 meshconf_psel;
>         u32 meshconf_pmetric;
>         u32 meshconf_congest;
>         u32 meshconf_synch;
>         u32 meshconf_auth;
>         u8 meshconf_form;
>         u16 meshconf_cap;
> } __attribute__ ((packed));
> 
> 

My reference is 802.11s-D4.01, it says (7.3.2.95.1):

Element id: 1 octet,
Length: 1 octet,
Active path selection protocol identifier: 1 octet,
Active path selection metric identifier: 1 octet,
Congestion control mode identifier: 1 octet,
Synchronization protocol identifier: 1 octet,
Authentication protocol identifier: 1 octet,
Mesh formation info: 1 octet,
Mesh capability: 2 octets.

The length field is set to 8.

Thanks.
-- Max