From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nyi8e-0000IF-GR for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:58:32 -0400 Received: from [140.186.70.92] (port=43929 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyi8d-0000I5-6C for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nyi8b-0001yq-Os for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:58:31 -0400 Received: from verein.lst.de ([213.95.11.210]:47100) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyi8b-0001yd-Ex for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:58:29 -0400 Date: Mon, 5 Apr 2010 10:58:28 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] Re: [PATCH] Replace calls of old bdrv_open Message-ID: <20100405085828.GB12779@lst.de> References: <1270039576-11968-1-git-send-email-kwolf@redhat.com> <4BB34A58.8040106@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BB34A58.8040106@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Juan Quintela On Wed, Mar 31, 2010 at 03:12:56PM +0200, Kevin Wolf wrote: > > If I can have my pony, your patch is better than current behaviour :) > > Feel free to post a v2 that implements your version. :-) No real need for that, it can also be done as a separate path on top of this one. Note that there's also another interesting aspect to this - currently vl.c, monitor.c and the xen disk code uses bdrv_find_whitelisted_format, but various other places that can be called directly from qemu and not just qemu-img/qemu-io do the "full" guess. Taking the whitelist check into the guessing helper would sort this out.