From: Dan Carpenter <error27@gmail.com>
To: dri-devel@lists.sourceforge.net, alexdeucher@gmail.com
Subject: smatch: radeon: unsigned is never less than zero
Date: Mon, 5 Apr 2010 14:42:48 +0300 [thread overview]
Message-ID: <20100405114248.GP5265@bicker> (raw)
Hi list,
Smatch complains about this:
drivers/gpu/drm/radeon/radeon_display.c +563 radeon_compute_pll_legacy(115)
warn: unsigned 'error' is never less than zero.
561 if (pll->flags & RADEON_PLL_PREFER_CLOSEST_LOWER) {
562 error = freq - current_freq;
563 error = error < 0 ? 0xffffffff : error;
^^^^^^^^^
"error" is unsigned so it's never less than zero here.
564 } else
565 error = abs(current_freq - freq);
regards,
dan carpenter
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
reply other threads:[~2010-04-05 11:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405114248.GP5265@bicker \
--to=error27@gmail.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.