From: Thomas Rast <trast@student.ethz.ch>
To: Paul Mackerras <paulus@samba.org>
Cc: <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eelis van der Weegen <eelis@eelis.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/2] gitk --color-words
Date: Mon, 5 Apr 2010 12:21:37 +0200 [thread overview]
Message-ID: <201004051221.37965.trast@student.ethz.ch> (raw)
In-Reply-To: <20100405064018.GA4471@brick.ozlabs.ibm.com>
Paul Mackerras wrote:
> On Sat, Apr 03, 2010 at 08:06:18PM +0200, Thomas Rast wrote:
>
> > I wasn't really sure about the last point -- this makes things a bit
> > complicated since Paul will have to apply 2/2, and Junio will have to
> > take care to only pull from Paul once 1/2 is in.
>
> You mean that the patch will mean that gitk will break if the
> underlying git isn't new enough? I have been careful to avoid that
> sort of dependency as far as possible. Have a look at how this is
> handled for the --textconv and --submodule options in [getblobdiffs]
> and do something similar for --color-words, please.
Ok, I'll look into that.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2010-04-05 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 0:52 [RFC PATCH 0/2] gitk --color-words Thomas Rast
2010-03-31 0:52 ` [PATCH 1/2] Add diff --porcelain option for --color-words Thomas Rast
2010-03-31 0:52 ` [PATCH 2/2] gitk: add the equivalent of diff --color-words Thomas Rast
2010-03-31 12:04 ` Thomas Rast
2010-04-03 18:06 ` [PATCH v2 0/2] gitk --color-words Thomas Rast
2010-04-03 18:06 ` [PATCH v2 1/2] Add diff --porcelain option for --color-words Thomas Rast
2010-04-03 19:15 ` Junio C Hamano
2010-04-03 22:38 ` Miles Bader
2010-04-03 18:06 ` [PATCH v2 2/2] gitk: add the equivalent of diff --color-words Thomas Rast
2010-04-05 6:40 ` [PATCH v2 0/2] gitk --color-words Paul Mackerras
2010-04-05 10:21 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004051221.37965.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=eelis@eelis.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.