From: Paul Moore <paul.moore@hp.com>
To: Joe Nall <joe@nall.com>
Cc: selinux@tycho.nsa.gov
Subject: Re: [PATCH] selinux: UNIX domain socket fixes
Date: Mon, 5 Apr 2010 16:16:06 -0400 [thread overview]
Message-ID: <201004051616.06832.paul.moore@hp.com> (raw)
In-Reply-To: <1A4A075E-8B71-467D-97D2-1957F38B8F57@nall.com>
On Monday 05 April 2010 03:28:12 pm Joe Nall wrote:
> On Apr 5, 2010, at 2:01 PM, Paul Moore wrote:
> > Correct a problem where we weren't setting the peer label correctly on
> > connected UNIX domain sockets and do some other general fixup while we
> > are messing with the code.
> >
> > Signed-off-by: Paul Moore <paul.moore@hp.com>
>
> Paul,
> Do you have a before/after test case?
Not really a before/after no, as I don't have anything that really performs a
getpeercon() on the client end as typically only the server side cares about
the peer's label (or at least that has been my experience). What I did test
was to make sure I didn't see any regressions in the UNIX stream socket
connections. To accomplish that I tweaked a little SELinux aware server I use
for testing INET sockets to make it work with UNIX sockets and connected to it
with socat at a variety of different levels, making sure getpeercon() always
displayed the correct level over a UNIX socket connection.
You can find a copy of my little test server at the URL below; I will caution
you it isn't particularly well written but it works well for situations like
these.
* http://free.linux.hp.com/~pmoore/files/getpeercon_server.c
--
paul moore
linux @ hp
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-04-05 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 19:01 [PATCH] selinux: UNIX domain socket fixes Paul Moore
2010-04-05 19:28 ` Joe Nall
2010-04-05 20:16 ` Paul Moore [this message]
2010-04-08 15:45 ` Paul Moore
2010-04-08 16:01 ` Eric Paris
2010-04-08 16:07 ` Paul Moore
2010-04-08 17:15 ` Stephen Smalley
2010-04-08 18:33 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004051616.06832.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=joe@nall.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.