From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nytxk-0002SX-B1
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 17:36:04 -0400
Received: from [140.186.70.92] (port=55160 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NytxR-0001ro-Ef
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 17:36:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Nytvv-0000CN-7y
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 17:34:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11063)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Nytvv-0000C0-0G
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 17:34:11 -0400
Date: Tue, 6 Apr 2010 00:30:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100405213027.GA9662@redhat.com>
References: <1270158985-13119-1-git-send-email-weil@mail.berlios.de>
	<20100404085951.GB3189@redhat.com>
	<4BBA256C.8060206@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4BBA256C.8060206@mail.berlios.de>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] win32: Fix compiler errors from u_int64_t
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, Apr 05, 2010 at 08:01:16PM +0200, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Thu, Apr 01, 2010 at 11:56:25PM +0200, Stefan Weil wrote:
> >> u_int64_t raises compiler error messages:
> >>
> >> CC libhw32/virtio.o
> >> /qemu/ar7/hw/virtio.c: In function =E2=80=98virtio_queue_get_avail_s=
ize=E2=80=99:
> >> /qemu/ar7/hw/virtio.c:776: error: =E2=80=98u_int64_t=E2=80=99 undecl=
ared (first use
> >> in this function)
> >> /qemu/ar7/hw/virtio.c:776: error: (Each undeclared identifier is
> >> reported only once
> >> /qemu/ar7/hw/virtio.c:776: error: for each function it appears in.)
> >>
> >> Replacing u_int64_t by uint64_t helps.
> >>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Cc: Anthony Liguori <aliguori@us.ibm.com>
> >> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Speaking of which, we have:
> > /scm/qemu/slirp/slirp.h:typedef uint64_t u_int64_t;
> >
> > which we probably don't need either?
>=20
> Right. I'd even prefer replacing all those u_int#_t types
> by the standard types uint#_t.
>=20
> Is that ok, or would you prefer not to touch the slirp code
> (which makes heavy use of those types)?
>=20
> Regards,
> Stefan

I don't think we should modify all of slirp code. However
u_int64_t specifically seems unused.

--=20
MST