From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device Date: Tue, 6 Apr 2010 00:03:01 +0100 Message-ID: <20100405230301.GF32401@fluff.org.uk> References: <20100311174830.4824.19820.stgit@angua> <20100311180649.4824.10368.stgit@angua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100311180649.4824.10368.stgit@angua> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org, jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, James.Bottomley-l3A5Bk7waGM@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: alsa-devel@alsa-project.org On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote: > .node is being removed > > Signed-off-by: Grant Likely > --- > > sound/soc/fsl/mpc8610_hpcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c > index ef67d1c..d7e1b9a 100644 > --- a/sound/soc/fsl/mpc8610_hpcd.c > +++ b/sound/soc/fsl/mpc8610_hpcd.c > @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = { > static int mpc8610_hpcd_probe(struct of_device *ofdev, > const struct of_device_id *match) > { > - struct device_node *np = ofdev->node; > + struct device_node *np = ofdev->dev.of_node; > struct device_node *codec_np = NULL; > struct device_node *guts_np = NULL; > struct device_node *dma_np = NULL; This looks like one case where an inline function would have been a help. -- Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kira.home.fluff.org (aeryn.fluff.org.uk [87.194.8.8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 47E27B7D0A for ; Tue, 6 Apr 2010 09:38:59 +1000 (EST) Date: Tue, 6 Apr 2010 00:03:01 +0100 From: Ben Dooks To: Grant Likely Subject: Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device Message-ID: <20100405230301.GF32401@fluff.org.uk> References: <20100311174830.4824.19820.stgit@angua> <20100311180649.4824.10368.stgit@angua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100311180649.4824.10368.stgit@angua> Cc: alsa-devel@alsa-project.org, gregkh@suse.de, linux-ide@vger.kernel.org, James.Bottomley@suse.de, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, jeremy.kerr@canonical.com, sfr@canb.auug.org.au, linux-scsi@vger.kernel.org, jgarzik@pobox.com, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, ben-linux@fluff.org, monstr@monstr.eu, linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dwmw2@infradead.org, davem@davemloft.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote: > .node is being removed > > Signed-off-by: Grant Likely > --- > > sound/soc/fsl/mpc8610_hpcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c > index ef67d1c..d7e1b9a 100644 > --- a/sound/soc/fsl/mpc8610_hpcd.c > +++ b/sound/soc/fsl/mpc8610_hpcd.c > @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = { > static int mpc8610_hpcd_probe(struct of_device *ofdev, > const struct of_device_id *match) > { > - struct device_node *np = ofdev->node; > + struct device_node *np = ofdev->dev.of_node; > struct device_node *codec_np = NULL; > struct device_node *guts_np = NULL; > struct device_node *dma_np = NULL; This looks like one case where an inline function would have been a help. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Mon, 05 Apr 2010 23:03:01 +0000 Subject: Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in Message-Id: <20100405230301.GF32401@fluff.org.uk> List-Id: References: <20100311174830.4824.19820.stgit@angua> <20100311180649.4824.10368.stgit@angua> In-Reply-To: <20100311180649.4824.10368.stgit@angua> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Grant Likely Cc: monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org, jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, James.Bottomley-l3A5Bk7waGM@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote: > .node is being removed > > Signed-off-by: Grant Likely > --- > > sound/soc/fsl/mpc8610_hpcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c > index ef67d1c..d7e1b9a 100644 > --- a/sound/soc/fsl/mpc8610_hpcd.c > +++ b/sound/soc/fsl/mpc8610_hpcd.c > @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = { > static int mpc8610_hpcd_probe(struct of_device *ofdev, > const struct of_device_id *match) > { > - struct device_node *np = ofdev->node; > + struct device_node *np = ofdev->dev.of_node; > struct device_node *codec_np = NULL; > struct device_node *guts_np = NULL; > struct device_node *dma_np = NULL; This looks like one case where an inline function would have been a help. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756901Ab0DEXEc (ORCPT ); Mon, 5 Apr 2010 19:04:32 -0400 Received: from aeryn.fluff.org.uk ([87.194.8.8]:14753 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756816Ab0DEXE0 (ORCPT ); Mon, 5 Apr 2010 19:04:26 -0400 Date: Tue, 6 Apr 2010 00:03:01 +0100 From: Ben Dooks To: Grant Likely Cc: monstr@monstr.eu, gregkh@suse.de, benh@kernel.crashing.org, akpm@linux-foundation.org, davem@davemloft.net, sfr@canb.auug.org.au, jgarzik@pobox.com, ben-linux@fluff.org, dwmw2@infradead.org, jeremy.kerr@canonical.com, James.Bottomley@suse.de, broonie@opensource.wolfsonmicro.com, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device Message-ID: <20100405230301.GF32401@fluff.org.uk> References: <20100311174830.4824.19820.stgit@angua> <20100311180649.4824.10368.stgit@angua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100311180649.4824.10368.stgit@angua> X-Disclaimer: These are my own opinions, so there! User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote: > .node is being removed > > Signed-off-by: Grant Likely > --- > > sound/soc/fsl/mpc8610_hpcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c > index ef67d1c..d7e1b9a 100644 > --- a/sound/soc/fsl/mpc8610_hpcd.c > +++ b/sound/soc/fsl/mpc8610_hpcd.c > @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = { > static int mpc8610_hpcd_probe(struct of_device *ofdev, > const struct of_device_id *match) > { > - struct device_node *np = ofdev->node; > + struct device_node *np = ofdev->dev.of_node; > struct device_node *codec_np = NULL; > struct device_node *guts_np = NULL; > struct device_node *dma_np = NULL; This looks like one case where an inline function would have been a help. -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'