From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [GIT PULL] break implicit percpu.h -> slab.h dependency
Date: Tue, 6 Apr 2010 11:50:12 +0200 [thread overview]
Message-ID: <20100406095012.GA23593@elte.hu> (raw)
In-Reply-To: <4BBB0118.307@kernel.org>
* Tejun Heo <tj@kernel.org> wrote:
> Hello, Ingo.
>
> On 04/06/2010 06:25 PM, Ingo Molnar wrote:
> > FYI, -tip testing found a build breakage with your changes:
> >
> > drivers/base/node.c:373: error: implicit declaration of function 'kmalloc'
> > drivers/base/node.c:377: error: implicit declaration of function 'kfree'
>
> These are NODEMASK_ALLOC() and NODEMASK_FREE() macros which become
> kmalloc/kfree() iff NODES_SHIFT > 8. I'll grep for these macros and
> commit a proper fix.
>
> > The fix is below. Since my first test today triggered a build failure i'd
> > expect there to be more - i'll send all subsequent fixes to this thread.
>
> Thanks. Much appreciated.
It's looking pretty good so far with about a dozen tests passed. Thanks for
doing this transition so carefully!
Ingo
next prev parent reply other threads:[~2010-04-06 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 3:50 [GIT PULL] break implicit percpu.h -> slab.h dependency Tejun Heo
2010-04-06 9:25 ` Ingo Molnar
2010-04-06 9:38 ` Tejun Heo
2010-04-06 9:50 ` Ingo Molnar [this message]
2010-04-06 21:41 ` [PATCH #slabh] nodemask: include slab.h from drivers/base/node.c Tejun Heo
2010-04-06 21:53 ` [GIT PULL] break implicit percpu.h -> slab.h dependency Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406095012.GA23593@elte.hu \
--to=mingo@elte.hu \
--cc=Lee.Schermerhorn@hp.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.