From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM
Date: Wed, 7 Apr 2010 02:00:22 +0100 [thread overview]
Message-ID: <201004070200.23054.paul@codesourcery.com> (raw)
In-Reply-To: <1270554249-24861-7-git-send-email-weil@mail.berlios.de>
> To emulate hardware without an EEPROM,
> EEPROM_SIZE may be set to 0.
If might, but it isn't.
This patch introduces a condition that will never be false. Please don't do
that. I consider code that is never used to be actively harmful. Any feature
that requires the user hack the source may as well not exist. The only
possible exception is debug output intended solely for qemu developers.
If there's something worth noting for future reference then add a proper
comment, if necessary marked as TODO/FIXME.
Paul
next prev parent reply other threads:[~2010-04-07 1:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 11:44 [Qemu-devel] eepro100: New patches Stefan Weil
2010-04-06 11:44 ` [Qemu-devel] [PATCH 1/9] eepro100: Don't allow writing SCBStatus Stefan Weil
2010-04-06 11:44 ` [Qemu-devel] [PATCH 2/9] eepro100: Simplify status handling Stefan Weil
2010-04-06 12:18 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-06 14:29 ` Stefan Weil
2010-04-06 14:34 ` Michael S. Tsirkin
2010-04-06 11:44 ` [Qemu-devel] [PATCH 3/9] eepro100: Simplified device instantiation Stefan Weil
2010-04-06 11:44 ` [Qemu-devel] [PATCH 4/9] eepro100: Add new device variant i82801 Stefan Weil
2010-04-06 11:44 ` [Qemu-devel] [PATCH 5/9] eepro100: Set configuration bit for standard TCB Stefan Weil
2010-04-06 11:44 ` [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM Stefan Weil
2010-04-06 12:10 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-06 14:26 ` Stefan Weil
2010-04-06 15:44 ` [Qemu-devel] " Richard Henderson
2010-04-06 16:01 ` Stefan Weil
2010-04-06 16:35 ` Richard Henderson
2010-04-07 1:00 ` Paul Brook [this message]
2010-04-07 7:02 ` Stefan Weil
2010-04-07 7:29 ` Michael S. Tsirkin
2010-04-06 11:44 ` [Qemu-devel] [PATCH 7/9] eepro100: Set power management capability using pci_reserve_capability Stefan Weil
2010-04-06 12:09 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-06 11:44 ` [Qemu-devel] [PATCH 8/9] eepro100: Fix mapping of flash memory Stefan Weil
2010-04-06 11:57 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-06 14:23 ` Stefan Weil
2010-04-06 14:30 ` Michael S. Tsirkin
2010-04-06 11:44 ` [Qemu-devel] [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression Stefan Weil
2010-04-06 11:55 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-06 12:40 ` [Qemu-devel] Re: eepro100: New patches Michael S. Tsirkin
2010-04-06 16:09 ` Stefan Weil
2010-04-07 8:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004070200.23054.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.