From: Felipe Balbi <felipe.balbi@nokia.com>
To: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: [PATCH] arm: omap1: fix section mismatch on clk_init()
Date: Wed, 7 Apr 2010 12:35:27 +0300 [thread overview]
Message-ID: <20100407093527.GX16297@nokia.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 70 bytes --]
Adding linux-omap to the loop.
Sorry, I had forgotten it.
--
balbi
[-- Attachment #2: Type: message/rfc822, Size: 2795 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 613 bytes --]
Hi Paul,
I thought you had fixed the section mismatch below, but for some reason
it came up again. Attached is a patch to fix it:
WARNING: arch/arm/mach-omap1/built-in.o(.data+0x264): Section mismatch
in reference from the variable omap1_clk_functions to the function
.init.text:omap1_clk_disable_unused()
The variable omap1_clk_functions references
the function __init omap1_clk_disable_unused()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the
variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one,
*_console,
--
balbi
[-- Attachment #2.1.2: 0001-arm-omap1-clk-fix-section-mismatch-on-clk_init.diff --]
[-- Type: text/x-diff, Size: 1484 bytes --]
>From a3b069cca760276d5eb2905e27939edf08b92797 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <felipe.balbi@nokia.com>
Date: Wed, 7 Apr 2010 12:30:48 +0300
Subject: [PATCH] arm: omap1: clk: fix section mismatch on clk_init
remove the section annotation from omap1_clk_disable_unused()
to kill the section mismatch warning.
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
arch/arm/mach-omap1/clock.c | 2 +-
arch/arm/mach-omap1/clock.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
index e0aec10..6bbb1b8 100644
--- a/arch/arm/mach-omap1/clock.c
+++ b/arch/arm/mach-omap1/clock.c
@@ -578,7 +578,7 @@ int omap1_clk_set_rate(struct clk *clk, unsigned long rate)
#ifdef CONFIG_OMAP_RESET_CLOCKS
-void __init omap1_clk_disable_unused(struct clk *clk)
+void omap1_clk_disable_unused(struct clk *clk)
{
__u32 regval32;
diff --git a/arch/arm/mach-omap1/clock.h b/arch/arm/mach-omap1/clock.h
index a4190af..75d0d7d 100644
--- a/arch/arm/mach-omap1/clock.h
+++ b/arch/arm/mach-omap1/clock.h
@@ -39,7 +39,7 @@ extern long omap1_clk_round_rate_ckctl_arm(struct clk *clk, unsigned long rate);
extern unsigned long omap1_watchdog_recalc(struct clk *clk);
#ifdef CONFIG_OMAP_RESET_CLOCKS
-extern void __init omap1_clk_disable_unused(struct clk *clk);
+extern void omap1_clk_disable_unused(struct clk *clk);
#else
#define omap1_clk_disable_unused NULL
#endif
--
1.7.0.rc0.33.g7c3932
next reply other threads:[~2010-04-07 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 9:35 Felipe Balbi [this message]
2010-04-23 0:37 ` [PATCH] arm: omap1: fix section mismatch on clk_init() Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407093527.GX16297@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.