From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 7 Apr 2010 11:25:01 -0500 Subject: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx. In-Reply-To: References: <1270219748-4930-1-git-send-email-michael.zaidman@gmail.com> <20100406194050.f4606e7a.kim.phillips@freescale.com> Message-ID: <20100407162501.GA9249@loki.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Apr 07, 2010 at 09:30:55AM -0500, Timur Tabi wrote: > On Tue, Apr 6, 2010 at 7:40 PM, Kim Phillips wrote: > > >> > You should add a comment explaining why you're not using I/O > >> > accessors. > >> > >> Ok, I will add the explanation. > > > > use raw i/o accessors please. > > But what about his performance concern? Shouldn't it be okay for him > to do direct writes and then follow-up with a sync(), as long as he > comments it? That's exactly what raw accessors are for. They don't include synchronization (and unfortunately this somehow gets tied up in whether endian conversions are done). -Scott