From: Chris Webb <chris@arachsys.com>
To: kusmabite@gmail.com
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Replace hard-coded path with one from <paths.h>
Date: Thu, 8 Apr 2010 11:58:51 +0100 [thread overview]
Message-ID: <20100408105850.GD2146@arachsys.com> (raw)
In-Reply-To: <n2u40aa078e1004070357m143cfaccvdc754a3bc5fe1ae1@mail.gmail.com>
Erik Faye-Lund <kusmabite@googlemail.com> writes:
> > +#include <paths.h>
>
> This breaks on Windows due to missing paths.h. I guess you need some
> guard to detect if the header is present or not.
Is this true of all WIN32, or just __MINGW32__ / __CYGWIN__? Presumably
/usr/local/bin:/usr/bin:/bin is the wrong default PATH on windows too, so
perhaps I should sort that at the same point---what would a canonical
default PATH be for Windows?
Cheers,
Chris.
next prev parent reply other threads:[~2010-04-08 11:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 20:48 [PATCH] Replace hard-coded path with one configurable at make time Chris Webb
2010-04-04 21:38 ` Junio C Hamano
2010-04-04 22:28 ` Chris Webb
2010-04-06 16:35 ` Chris Webb
2010-04-06 16:36 ` [PATCH] Replace hard-coded path with one from <paths.h> Chris Webb
2010-04-07 10:57 ` Erik Faye-Lund
2010-04-08 10:58 ` Chris Webb [this message]
2010-04-08 11:26 ` Erik Faye-Lund
2010-04-08 11:57 ` [PATCH v2] " Chris Webb
2010-04-08 12:08 ` Erik Faye-Lund
2010-04-09 5:45 ` Chris Webb
2010-04-13 9:06 ` Chris Webb
2010-04-13 9:07 ` [PATCH v3] " Chris Webb
2010-04-13 20:01 ` Junio C Hamano
2010-04-14 7:22 ` Chris Webb
2010-04-15 12:27 ` Jakub Narebski
2010-04-15 19:15 ` Junio C Hamano
2010-04-15 12:25 ` Jakub Narebski
2010-04-15 12:40 ` Chris Webb
2010-04-15 12:57 ` Jakub Narebski
2010-04-15 13:01 ` Chris Webb
2010-04-15 13:21 ` [PATCH v4] " Chris Webb
2010-04-09 23:54 ` [PATCH] " Tait
2010-04-06 16:57 ` [PATCH] git-instaweb: pass through invoking user's path to gitweb CGI script Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408105850.GD2146@arachsys.com \
--to=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.