From: Li Dongyang <lidongyang@novell.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: alloc orphaned inode in ocfs2_symlink
Date: Fri, 9 Apr 2010 10:32:42 +0800 [thread overview]
Message-ID: <201004091032.42548.lidongyang@novell.com> (raw)
In-Reply-To: <20100408211222.GC20661@mail.oracle.com>
On Friday 09 April 2010 05:12:22 Joel Becker wrote:
> On Thu, Apr 08, 2010 at 09:13:08AM +0800, Li Dongyang wrote:
> > alloc the inode orphaned in ocfs2_symlink so we can delete the inode
> > in the iput if we meet errors with the inode, e.g. ocfs2_add_inode_data.
> > or ocfs2_query_inode_wipe will complain the inode is not orphaned on
> > disk.
>
> Huh. At first I was sure this was ok, as the iput is sanely
> killing the inode. But you're right, the wipe code expects it to be
> orphaned.
> Do you have a testcase for this?
>
> Joel
>
I found it while trying to reproduce the bug fixed by the patch ocfs2: avoid
direct write if we fall back to buffered.
In my case, just run fsstress on a single node, and when the ocfs2 partition
is out of space, ocfs2_add_inode_data will return -ENOSPC and then will
trigger the error in ocfs2_query_inode_wipe
next prev parent reply other threads:[~2010-04-09 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 1:13 [Ocfs2-devel] [PATCH] ocfs2: alloc orphaned inode in ocfs2_symlink Li Dongyang
2010-04-08 21:12 ` Joel Becker
2010-04-09 2:32 ` Li Dongyang [this message]
2010-04-08 23:10 ` Mark Fasheh
2010-04-09 2:37 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004091032.42548.lidongyang@novell.com \
--to=lidongyang@novell.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.