From: Greg KH <gregkh@suse.de>
To: Gunnar Gudvardarson <gunni@wave.is>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean
Date: Fri, 9 Apr 2010 10:22:50 -0700 [thread overview]
Message-ID: <20100409172250.GA15900@suse.de> (raw)
In-Reply-To: <1270818069-3400-1-git-send-email-gunni@wave.is>
On Fri, Apr 09, 2010 at 01:01:09PM +0000, Gunnar Gudvardarson wrote:
> This is the first linux kernel patch i have ever made, i don't even
> know the C programming language except reading the syntax (basic)
Then I would strongly encourage you to either learn it, or not modify
the code.
> It didn't compile on my machine due to invalid configuration of something
> on my machine, because i have not yet learned how to configure the compiler.
Especially as you were not able to build test the patch, which is a
basic requirement for submitting code changes.
Try reading the kernel file, Documentation/HOWTO for pointers on how to
find information to learn the C language, and to learn how to build a
kernel on your own.
best of luck,
greg k-h
prev parent reply other threads:[~2010-04-09 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 13:01 [PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean Gunnar Gudvardarson
2010-04-09 17:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100409172250.GA15900@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=gunni@wave.is \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.