From: Arnd Bergmann <arnd@arndb.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] random: Forbid llseek on random chardev
Date: Sat, 10 Apr 2010 19:55:46 +0200 [thread overview]
Message-ID: <201004101955.46644.arnd@arndb.de> (raw)
In-Reply-To: <20100410163529.GI5204@nowhere>
On Saturday 10 April 2010 18:35:30 Frederic Weisbecker wrote:
>
> > > Using generic_file_llseek means we no longer need to
> > > take the BKL if anyone tries to seek on these.
> >
> > Comment doesn't match the patch?
Yes, my fault. The version in my series already had this problem.
> Oops. I guess the patch has been updated, but not the changelog.
>
> Some background: we are trying to remove the uses of default_llseek
> that use the bkl. We started with turning llseek stubs to
> generic_file_llseek (or non seekable open in some cases), but we are
> hesitating now and think about actually turn all the stubs that
> might need the bkl into default_llseek, and fallback to
> generic_file_llseek for all other stubs.
>
> Depending on what we do I'll resend you an updated version
> of this patch with generic_file_llseek, or I will let the stub
> as is.
The noop_llseek from Jan's series seems most appropriate here.
Arnd
prev parent reply other threads:[~2010-04-10 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 14:17 [PATCH] random: Forbid llseek on random chardev Frederic Weisbecker
2010-04-10 16:25 ` Matt Mackall
2010-04-10 16:35 ` Frederic Weisbecker
2010-04-10 16:59 ` Matt Mackall
2010-04-10 17:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004101955.46644.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.