All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: LOCALVERSION_AUTO considered harmful
Date: Sun, 11 Apr 2010 18:47:01 +0200	[thread overview]
Message-ID: <20100411164701.GA7558@elf.ucw.cz> (raw)

LOCALVERSION_AUTO has nasty interaction with modules, warn about it.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/init/Kconfig b/init/Kconfig
index eb77e8c..5d33072 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -88,7 +88,6 @@ config LOCALVERSION
 
 config LOCALVERSION_AUTO
 	bool "Automatically append version information to the version string"
-	default y
 	help
 	  This will try to automatically determine if the current tree is a
 	  release tree by looking for git tags that belong to the current
@@ -99,6 +98,11 @@ config LOCALVERSION_AUTO
 	  appended after any matching localversion* files, and after the value
 	  set in CONFIG_LOCALVERSION.
 
+	  Unfortunately, such finegrained versioning will mean that you will
+	  not be able to use modules for development; even "make modules"
+	  will change module versions, making recompiled modules impossible
+	  to insert into old kernel. 
+
 	  (The actual string used here is the first eight characters produced
 	  by running the command:
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2010-04-11 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-11 16:47 Pavel Machek [this message]
2010-04-12 18:51 ` LOCALVERSION_AUTO considered harmful Alexey Dobriyan
2010-04-11 18:58   ` Geert Uytterhoeven
2010-04-11 20:14     ` Pavel Machek
2010-04-11 22:24       ` Thomas Gleixner
2010-04-12  1:20         ` rdunlap
2010-04-12  2:56         ` rdunlap
2010-04-12  3:49           ` Randy Dunlap
2010-04-12 12:48           ` Theodore Tso
2010-04-12 13:14         ` Pavel Machek
2010-04-12 17:03           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100411164701.GA7558@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.