From: Denys Fedorysychenko <nuclearcat@nuclearcat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Krishna Kumar <krkumar2@in.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: NULL pointer dereference panic in stable (2.6.33.2), amd64
Date: Mon, 12 Apr 2010 02:04:11 +0300 [thread overview]
Message-ID: <201004120204.11405.nuclearcat@nuclearcat.com> (raw)
In-Reply-To: <1271025353.2078.155.camel@edumazet-laptop>
> It is IMHO not safe, because route for this socket might have just
> changed and we are transmitting an old packet (queued some milli seconds
> before, when route was different).
>
> We then memorize a queue_index that might be too big for the new device
> of new selected route.
>
> Next packet we want to transmit will take the cached value of
> queue_index, correct for old device, maybe not correct for new device.
Yes, it is possible, i have there RIP with 1k+ routes, changing non-stop.
>
> You could try to revert commit a4ee3ce3293dc931fab19beb472a8bde1295aebe
>
> commit a4ee3ce3293dc931fab19beb472a8bde1295aebe
I will try to revert it now. But to trigger bug probably i need 1-2 days.
next prev parent reply other threads:[~2010-04-11 23:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-11 20:38 NULL pointer dereference panic in stable (2.6.33.2), amd64 Denys Fedorysychenko
2010-04-11 22:35 ` Eric Dumazet
2010-04-11 23:04 ` Denys Fedorysychenko [this message]
2010-04-11 23:11 ` Eric Dumazet
2010-04-11 23:36 ` Denys Fedorysychenko
2010-04-12 3:38 ` Krishna Kumar2
2010-04-12 6:01 ` Eric Dumazet
2010-04-12 7:18 ` Eric Dumazet
2010-04-12 7:36 ` David Miller
2010-04-15 6:52 ` David Miller
2010-04-15 8:02 ` Eric Dumazet
2010-04-15 8:26 ` David Miller
2010-04-15 8:51 ` Eric Dumazet
2010-04-15 9:06 ` David Miller
2010-04-15 9:11 ` Denys Fedorysychenko
2010-04-15 10:37 ` Eric Dumazet
2010-04-29 10:50 ` Denys Fedorysychenko
2010-04-15 20:30 ` Eric Dumazet
2010-04-15 20:46 ` Eric Dumazet
2010-04-15 21:33 ` David Miller
2010-04-16 22:18 ` [PATCH net-next-2.6] net: Introduce skb_orphan_try() Eric Dumazet
2010-04-18 9:46 ` David Miller
2010-04-21 6:08 ` Eric Dumazet
2010-04-22 5:56 ` David Miller
2010-04-22 7:10 ` Eric Dumazet
2010-04-22 7:16 ` David Miller
2010-04-22 7:24 ` Eric Dumazet
2010-04-22 7:26 ` David Miller
2010-04-22 7:33 ` Eric Dumazet
2010-04-22 7:41 ` David Miller
2010-04-22 7:47 ` Eric Dumazet
2010-04-22 7:54 ` David Miller
2010-04-22 7:59 ` Eric Dumazet
2010-04-12 7:54 ` NULL pointer dereference panic in stable (2.6.33.2), amd64 Krishna Kumar2
2010-04-12 9:31 ` Eric Dumazet
2010-04-12 16:11 ` Denys Fedorysychenko
2010-04-12 20:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004120204.11405.nuclearcat@nuclearcat.com \
--to=nuclearcat@nuclearcat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.