From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCHv2 5/10] xfs: encapsulate bbcount validity checking
Date: Mon, 12 Apr 2010 16:35:14 +1000 [thread overview]
Message-ID: <20100412063513.GH2493@dastard> (raw)
In-Reply-To: <1270852091.7840.143.camel@doink>
On Fri, Apr 09, 2010 at 05:28:11PM -0500, Alex Elder wrote:
> Define a function that encapsulates checking the validity of a log
> block count.
>
> (Updated from previous version--no longer includes error reporting in the
> encapsulated validation function.)
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <david@fromorbit.com>
but one small change needed:
>
> +/*
> + * Verify the given count of basic blocks is valid number of blocks
> + * to specify for an operation involving the given XFS log buffer.
> + * Returns nonzero if the count is valid, 0 otherwise.
> + */
> +
> +inline static int
static inline int
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-13 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 22:28 [PATCHv2 5/10] xfs: encapsulate bbcount validity checking Alex Elder
2010-04-12 6:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412063513.GH2493@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.