All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: Local unset override global options
Date: Mon, 12 Apr 2010 19:02:07 +0200	[thread overview]
Message-ID: <201004121902.08345.jnareb@gmail.com> (raw)
In-Reply-To: <7v1vekn05h.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > How does special case of no value, i.e.
> >
> >    [sendemail]
> >         smtpuser
> 
> That is not a special case; that is "boolean true".

Well, it is "boolean true" *if* git-config is used with '--bool'.

If git-send-email.perl used "git config -l -z" to read all its config 
variables at once into hash, like gitweb.perl does in the 
git_parse_project_config() subroutine, it would be able to distinguish 
between those the case of no value:

    [sendemail]
         smtpuser

(in which case "exists $config{'sendemail.smptuser'}" but "not defined 
$config{'sendemail.smtpuser'}", and of empty value

    [sendemail]
         smtpuser = ""

(in which case it is "defined $config{'sendemail.smtpuser'}" but not
true "$config{'sendemail.smtpuser'}).


But as git-send-email.perl uses Git::config to read config variables
one by one (equivalent to "git config --get <variable>"), I think that
also in the case of no value you would end up with $smtp_authuser
defined but empty (and false).


P.S. I wonder if 'sendemail.<identity>' section and 'sendemail.identity'
could help with original problem...
-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-04-12 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-10  6:54 Local unset override global options Stefan Hajnoczi
2010-04-12  8:13 ` Michael J Gruber
2010-04-12  8:23   ` Stefan Hajnoczi
2010-04-12  8:28     ` Michael J Gruber
2010-04-12  8:53       ` Jakub Narebski
2010-04-12 15:47         ` Junio C Hamano
2010-04-12 17:02           ` Jakub Narebski [this message]
2010-04-12 18:18             ` Junio C Hamano
2010-04-12 18:36               ` Erik Faye-Lund
2010-04-12 21:07               ` Jakub Narebski
2010-04-12  8:35   ` Junio C Hamano
2010-04-12  8:43     ` Stefan Hajnoczi
2010-04-12 15:48       ` Junio C Hamano
2010-04-12 16:07         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004121902.08345.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.