From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>, Anton Blanchard <anton@samba.org>
Cc: Paul Mackerras <paulus@samba.org>, linux-kernel@vger.kernel.org
Subject: TRACE_EVENT() declarations belong to include/trace/
Date: Mon, 12 Apr 2010 17:45:11 -0400 [thread overview]
Message-ID: <20100412214511.GA2699@Krystal> (raw)
Hi,
Ranting about:
commit 1bf4af165050d90ea6659ffb2536ec8ca783aab5
Author: Anton Blanchard <anton@samba.org>
Date: Mon Oct 26 18:47:42 2009 +0000
powerpc: tracing: Add powerpc tracepoints for interrupt entry and exit
Why are there TRACE_EVENT() declarations in arch/powerpc/include/asm/trace.h for
irq_entry/exit ?
What's so special about them that they cannot be put in linux/trace/ ?
I'm all for the trace_irq_entry/exit instrumentation, but I don't see any good
in adding event declarations outside of include/trace/.
Thanks,
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next reply other threads:[~2010-04-12 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 21:45 Mathieu Desnoyers [this message]
2010-04-12 22:01 ` TRACE_EVENT() declarations belong to include/trace/ Steven Rostedt
2010-04-12 22:04 ` Frederic Weisbecker
2010-04-12 22:17 ` Mathieu Desnoyers
2010-04-12 23:17 ` Anton Blanchard
2010-04-13 0:27 ` Mathieu Desnoyers
2010-04-12 23:24 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412214511.GA2699@Krystal \
--to=mathieu.desnoyers@efficios.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.