From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] p2m: merge ptp allocation
Date: Tue, 13 Apr 2010 12:34:08 +0200
Message-ID: <201004131234.09062.Christoph.Egger@amd.com>
References: <201004131125.40545.Christoph.Egger@amd.com>
	<20100413102221.GA4120@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100413102221.GA4120@whitby.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Tim Deegan <Tim.Deegan@citrix.com>, Keir Fraser <Keir.Fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tuesday 13 April 2010 12:22:21 Tim Deegan wrote:
> Hi,
>
> At 10:25 +0100 on 13 Apr (1271154340), Christoph Egger wrote:
> > Attached patch merges ptp allocation in p2m.
> >
> > Signed-off-by: Christoph Egger <Christop.Egger@amd.com>
> >
> > diff -r 105fdf064d27 xen/arch/x86/mm/hap/private.h
> > --- a/xen/arch/x86/mm/hap/private.h	Tue Apr 13 10:35:24 2010 +0200
> > +++ b/xen/arch/x86/mm/hap/private.h	Tue Apr 13 10:59:55 2010 +0200
> > @@ -30,5 +30,6 @@ unsigned long hap_gva_to_gfn_3_levels(st
> >  unsigned long hap_gva_to_gfn_4_levels(struct vcpu *v, unsigned long gva,
> >                                       uint32_t *pfec);
> >
> > +struct page_info *p2m_alloc_ptp(struct domain *d, unsigned long type);
>
> Why is this declared in hap/private.h when it's not a hap function?
> Maybe asm-x86/p2m.h would be a better place.

Ok, I'm fine with this change.
Keir: Do you want me to resend the diff or will you do that right before 
applying the patch?

>
> Otherwise, Ack.

Thanks.

> Tim.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632