From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxl: build fix
Date: Tue, 13 Apr 2010 13:49:44 +0200 [thread overview]
Message-ID: <201004131349.45308.Christoph.Egger@amd.com> (raw)
In-Reply-To: <19396.21435.748085.75231@mariner.uk.xensource.com>
On Tuesday 13 April 2010 13:21:31 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build fix"):
> > Attached patch makes libxl compile on NetBSD.
> > <sys/signal.h> is needed to get definition for SIGPIPE and SIG_IGN.
>
> <sys/signal.h> is not a standard header file. It should be <signal.h>.
>
> Adding
> #include <signal.h>
> would be correct.
On NetBSD, the SIG* defines are in <sys/signal.h> which is just
included by <signal.h>
On NetBSD, both works.
But you're right, the portable fix is the prefered one.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-04-13 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 10:16 [PATCH] libxl: build fix Christoph Egger
2010-04-13 11:21 ` Ian Jackson
2010-04-13 11:49 ` Christoph Egger [this message]
2010-04-13 15:04 ` Ian Jackson
2010-04-14 7:19 ` Christoph Egger
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 15:51 Christoph Egger
2012-05-17 11:41 ` Roger Pau Monne
2012-05-17 11:44 ` Ian Campbell
2012-05-17 13:47 ` Ian Campbell
2011-01-11 14:54 Christoph Egger
2011-01-11 18:44 ` Ian Jackson
2009-12-01 14:40 Christoph Egger
2009-12-04 15:52 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004131349.45308.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.